Skip to content

Fixes issue where arguments aren't passed to helm uninstall commands #21295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes issue where arguments aren't passed to helm uninstall commands #21295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e80ca37
Fixes issue where arguments ins't passed to helm uninstall commands
tomaustin700 Sep 3, 2025
9ddb1c7
Merge branch 'master' into master
tomaustin700 Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Tasks/HelmDeployV1/src/helmcommands/helmuninstall.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,16 @@ import helmcli from "../helmcli";

export async function addArguments(helmCli: helmcli): Promise<void> {
var releaseName = tl.getInput("releaseName", true);
var namespace = tl.getInput("namespace" , false);
var namespace = tl.getInput("namespace", false);
var argumentsInput = tl.getInput("arguments", false);

helmCli.addArgument(releaseName);

if (namespace) {
helmCli.addArgument("--namespace ".concat(namespace));
}
}

if (argumentsInput) {
helmCli.addArgument(argumentsInput);
}
}
2 changes: 1 addition & 1 deletion Tasks/HelmDeployV1/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"version": {
"Major": 1,
"Minor": 262,
"Patch": 3
"Patch": 4
},
"demands": [],
"groups": [
Expand Down