Skip to content

Conversation

@msgharpu
Copy link

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • [ 👍 ] I am making a change required for Microsoft usage of react-native

Summary

The libreactnativeutilsjni so file is just a subset of libreactnativejni. Including this is redundant.
Trying to see if this can be removed from MS fork

@msgharpu msgharpu requested a review from alloy as a code owner November 15, 2021 17:49
@pull-bot
Copy link

pull-bot commented Nov 15, 2021

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against df55b12

@HeyImChris
Copy link

Seems like a good candidate fix to make upstream in Facebook's fork?

@msgharpu
Copy link
Author

Seems like a good candidate fix to make upstream in Facebook's fork?

Yes. I'm still testing this with internal application build. If it doesn't break any Android experiences, will refine this patch and push another iteration for approval

@msgharpu msgharpu closed this Nov 16, 2021
@msgharpu
Copy link
Author

Created a new PR #901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants