Add support for inspect data v2 #4185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadmeste
force-pushed
the
always-encrypt-inspect-data-v2
branch
2 times, most recently
from
85ecc10 to
b485ab3
Compare
vadmeste
force-pushed
the
always-encrypt-inspect-data-v2
branch
from
b485ab3 to
454fac4
Compare
klauspost
reviewed
Oct 26, 2022
vadmeste
force-pushed
the
always-encrypt-inspect-data-v2
branch
from
115449c to
b821616
Compare
Contributor
|
@vadmeste Thinking about it maybe we should add a (functionaly it should jeg remove the public key) |
Member
Author
Done. I also tested with older MinIO version. This will necessarly return a key for the v1 format. I believe this is also what we want as well. |
vadmeste
force-pushed
the
always-encrypt-inspect-data-v2
branch
from
4c39c1f to
1d69673
Compare
klauspost
approved these changes
Oct 27, 2022
- Enforce data to be encrypted by default - Use the public key ~/.mc/support.pk to encrypt the data if found, otherwise, keep the old behavior which is receiving the encryption key from the server and prints it in the screen.
harshavardhana
force-pushed
the
always-encrypt-inspect-data-v2
branch
from
1d69673 to
fe90253
Compare
harshavardhana
force-pushed
the
always-encrypt-inspect-data-v2
branch
from
fe90253 to
400aecd
Compare
harshavardhana
approved these changes
Oct 29, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires minio/madmin-go#104
The new format is zip file which contains 'data.zip' which is encrypted;
'data.zip' will content the data from the server backend disks.
The code is also backward compatible with the older inspect format as
well