Skip to content

Conversation

@klauspost
Copy link
Contributor

@klauspost klauspost commented Oct 14, 2022

Depends on: minio/minio#15474 for functionality (which depends on this)

Blocks: minio/minio#15474

Keep v1 if non-encrypted and decrypt it.

Otherwise if encrypted, use a fixed public key.

Will not work until minio is upgraded with as well.

@klauspost
Copy link
Contributor Author

Still pending mc 4185, but short of go.mod updates it is ready for review.

@klauspost klauspost marked this pull request as ready for review October 26, 2022 14:01
@harshavardhana
Copy link
Member

@klauspost PTAL at the tests

=== RUN   TestInspect
=== RUN   TestInspect/Test_Invalid_Path
=== RUN   TestInspect/Test_Invalid_characters_in_Path
=== RUN   TestInspect/Test_valid_bucket
=== CONT  TestInspect
    inspect_test.go:99: 
        	Error Trace:	/home/runner/work/console/console/integration/inspect_test.go:99
        	Error:      	Not equal: 
        	            	expected: 200
        	            	actual  : 500
        	Test:       	TestInspect
=== RUN   TestInspect/Test_Empty_Path
--- FAIL: TestInspect (0.03s)
    --- PASS: TestInspect/Test_Invalid_Path (0.01s)
    --- PASS: TestInspect/Test_Invalid_characters_in_Path (0.01s)
    --- PASS: TestInspect/Test_valid_bucket (0.01s)
    --- PASS: TestInspect/Test_Empty_Path (0.01s)
=== RUN   TestLoginStrategy

@klauspost
Copy link
Contributor Author

@harshavardhana It is a cyclic dependency. Minio depends on this and this depends on minio

@harshavardhana
Copy link
Member

@harshavardhana It is a cyclic dependency. Minio depends on this and this depends on minio

Then can we skip it? @klauspost as a non-failure?

harshavardhana
harshavardhana previously approved these changes Oct 31, 2022
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot generate inspect files with encryption set as true:
Screenshot 2022-11-02 at 10 31 57

This seems related to the missing dependency from minio, will approve this to unblock the rest of required PRs

@klauspost
Copy link
Contributor Author

@bexsoft Yes, the encryption option requires the minio PR to be running to work (and the PR above requires this console version).

@harshavardhana harshavardhana merged commit 2ff44df into minio:master Nov 2, 2022
adfost pushed a commit to adfost/console that referenced this pull request Nov 18, 2022
Depends on: minio/minio#15474 for functionality
(which depends on this)

Blocks:  minio/minio#15474

Keep v1 if non-encrypted and decrypt it.

Otherwise if encrypted, use a fixed public key.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants