Skip TLS verif for local address #2323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested changes
Sep 20, 2022
Alevsk
suggested changes
Sep 20, 2022
harshavardhana
requested changes
Sep 23, 2022
harshavardhana
previously approved these changes
Sep 23, 2022
Member
|
PTAL at the failed tests @vadmeste |
harshavardhana
requested changes
Oct 3, 2022
harshavardhana
requested changes
Oct 3, 2022
added 2 commits
October 10, 2022 09:38
If CONSOLE_MINIO_URL is pointing to 127.0.0.1, skip the TLS verificatin
harshavardhana
approved these changes
Oct 15, 2022
Alevsk
approved these changes
Oct 17, 2022
Contributor
Alevsk
left a comment
Alevsk
left a comment
There was a problem hiding this comment.
Tested, works fine, this verification will only apply if the provided IP is 127.0.0.1
Member
Yes this must be done via server setting as well. MinIO must set this to local IP always for embedded console. // cc @vadmeste can you make this server change as well? |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Console is talking locally to MinIO, skip the TLS verification if any.
This will allow users to avoid defining the correct MINIO_SERVER_URL domain
address, when TLS is enabled, useful in a bare-metal setup.