feat(webview): Optionally display a webview on the home screen #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description As the title ### Test plan n/a ### Related issues n/a ### Backwards compatibility Y ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [ ] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
…lestack-runtime into jophish/test-branch
…lestack-runtime into jophish/test-branch
### Description To keep the changes minimal, I've removed the automated triggers to the unnecessary workflows: - workflows related to crowdin and translations (these fail when doing the project syncs because of new translations that modify the localised files) - nightly builds - productions builds limited to only mainnet (skip alfajores) - licences update ### Test plan n/a ### Related issues n/a ### Backwards compatibility Y ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [ ] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
…lestack-runtime into jophish/test-branch
### Description This PR gets the e2e tests working, and sets up the Namespace integration for the Android runners. ATM, all enabled e2e tests pass except for the WC tests, though this perhaps seems unrelated to this repo in particular? [See Slack thread](https://valora-app.slack.com/archives/C025V1D6F3J/p1726096062541629). ### Test plan <!-- Demonstrate the change is solid, or why it doesn't need testing. Example: add any manual testing steps or scenarios (if not obvious), screenshots / videos if the pull request changes the user interface. --> ### Related issues - Fixes #[issue number here] ### Backwards compatibility <!-- Brief explanation of why these changes are/are not backwards compatible. --> ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [ ] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
### Description Sets up WalletConnect to use separate projects, as well as fixes the CI. See [here](https://www.notion.so/valora-inc/TODO-s-for-creating-new-MS-apps-4ce7c636fc764ee6badeabe69c1866c6?pvs=4#c40a7bb4e67c4df38fa211413c65163b) for a list of instructions on how to set up WC in new repos. ### Test plan <!-- Demonstrate the change is solid, or why it doesn't need testing. Example: add any manual testing steps or scenarios (if not obvious), screenshots / videos if the pull request changes the user interface. --> ### Related issues - Fixes #[issue number here] ### Backwards compatibility <!-- Brief explanation of why these changes are/are not backwards compatible. --> ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [ ] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
### Description For [RET-1148](https://linear.app/valora/issue/RET-1148/[shell]-update-navigation-homewalletactivity). Updates navigation and home tabs to match designs. Also removes the Valora gradient from certain underlines throughout the app. ### Test plan Unit and manual tested. See video below. https://github.com/user-attachments/assets/c9c3e735-665c-4454-abe9-5ce0e4e06500 ### Related issues Fixes [RET-1148](https://linear.app/valora/issue/RET-1148/[shell]-update-navigation-homewalletactivity). ### Backwards compatibility <!-- Brief explanation of why these changes are/are not backwards compatible. --> ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For RET-1149. This is a bit of a hack, as the inline webview component is mostly just copy-pasted from our existing
WebViewScreenpage, though refactoring our existingWebViewScreento pull this functionality out would generate a potentially gnarly diff between Runtime and Valora. One option is to do that refactoring work in Valora proper, since there's seemingly no downside to it. Another option would be to just punt on this entirely, since there's actually no immediate need for this feature..Test plan
See video below (excuse the long wait at the end for the TX to show up in the feed!):
ms-webview-2024-09-17_01.05.39.mp4
Related issues
Backwards compatibility
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: