Discuss use of service classes / service module functions #231
Description
In this issue, we should consider:
- Should we wrap Jira client access in a class a-la Reorganize calls to Bugzilla into a dedicated class in
services.py#220? - When should we (and action authors) use module functions vs service class methods?
- What should the "responsibility" client and/or service classes be?
The purpose of this issue is mostly to be a venue for discussion.
The outcome of this issue should be new issues and/or an ADR.
Related:
Do you think we should have our own Jira class with such methods? Or can we establish a general guideline on when to use a module function and when to use a client method?
So, we only leave check_health at the module level. Would it make more sense to have it as a client method to align it with the rest of the actions code? eg. jira.get_client().check_health(actions) ?