Skip to content

Reorganize calls to Bugzilla into a dedicated class in services.py #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 29, 2022
Merged

Reorganize calls to Bugzilla into a dedicated class in services.py #220

merged 9 commits into from
Aug 29, 2022

Conversation

@leplatrem
Copy link
Contributor

@leplatrem leplatrem commented Aug 25, 2022 •
edited
Loading

@leplatrem leplatrem mentioned this pull request Aug 25, 2022
Merged
2 tasks
@leplatrem leplatrem marked this pull request as ready for review August 26, 2022 09:46
@leplatrem leplatrem requested a review from a team as a code owner August 26, 2022 09:46
@leplatrem leplatrem marked this pull request as draft August 26, 2022 10:08
@leplatrem leplatrem force-pushed the refactor-model-services branch from 576cd21 to 241405c Compare August 26, 2022 13:33
@leplatrem leplatrem changed the title Remove model attributes that call services Reorganize calls to Bugzilla into a dedicated class in services.py Aug 26, 2022
@leplatrem leplatrem marked this pull request as ready for review August 26, 2022 13:35
grahamalama
grahamalama reviewed Aug 26, 2022
View reviewed changes
grahamalama
grahamalama reviewed Aug 26, 2022
View reviewed changes
grahamalama
grahamalama reviewed Aug 26, 2022
View reviewed changes
bsieber-mozilla
bsieber-mozilla approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@bsieber-mozilla bsieber-mozilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change!

@leplatrem leplatrem mentioned this pull request Aug 29, 2022
Closed
@leplatrem leplatrem added the breaking-change Pull requests that introduce a breaking change label Aug 29, 2022
@leplatrem leplatrem merged commit a5ec7f6 into main Aug 29, 2022
@leplatrem leplatrem deleted the refactor-model-services branch August 29, 2022 13:30
@leplatrem
Copy link
Contributor Author

leplatrem commented Aug 29, 2022 •
edited
Loading

I'm adding the breaking-change label, because we renamed the metric from jbi.bugzilla.methods.getbug to jbi.bugzilla.methods.get_bug

@leplatrem leplatrem mentioned this pull request Aug 30, 2022
Merged
@grahamalama grahamalama mentioned this pull request Aug 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@grahamalama grahamalama grahamalama left review comments

@bsieber-mozilla bsieber-mozilla bsieber-mozilla approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking-change Pull requests that introduce a breaking change internal-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@leplatrem @grahamalama @bsieber-mozilla