Do not serialize raw Action objects and their callable (fixes #136, #137) #139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137
Fixes #136
I could reproduce these issues by:
.envmake starthttp :8000/__heartbeat__In order to force initialization of actions on the
/whiteboard_tags/endpoint I added this:And then, reaching out
/whiteboard_tags/would crash, trying to serialize:callableattribute)I could only fix it by using
.dict(exclude={"callable"})(or using model config and just.dict()as in the present patch)I failed at reproducing the situation in a unit test (naive version below):
because the issue comes from an internal urlib object that only gets initialized when session is established