Use exclude keyword in dict method to exclude Action callable field
#142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsieber-mozilla
approved these changes
Jul 22, 2022
Contributor
bsieber-mozilla
left a comment
bsieber-mozilla
left a comment
There was a problem hiding this comment.
LGTM; minor comment added.
Thanks for looking into this
grahamalama
force-pushed
the
exclude-callable-in-dict
branch
from
5010e31 to
35ff74d
Compare
The model config approach we used in d46eb39 seemed to help with the `/powered_by_jbi` endpoint, but we were still seeing failures in `/whiteboard_tags`. We found that using the .dict(exclude=<...>) method seemed to _acutally_ exclude the `callable` field.
grahamalama
force-pushed
the
exclude-callable-in-dict
branch
from
35ff74d to
73fc766
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-on to #139 (which addresses #136 and #137):
The model config approach we used in d46eb39 seemed to help with the
/powered_by_jbiendpoint, but errors were still appearing in/whiteboard_tags.We found that using the
action.dict(exclude=<...>)method seemed to actually exclude thecallablefield. (pydantic docs)It's unclear at this point why this method works and the model config approach doesn't.