chore: Fix various peer dependency warnings #2054

eps1lon · 2020-08-01T09:52:00Z

Please don't ignore these warnings. They're almost always correct.

It's especially important to align the main monorepo and the pickers monorepo. This should make integrating easier since the workspaces in pickers no longer rely on the whole dependency tree but can live on their own.

vercel · 2020-08-01T09:52:04Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mui-org/material-ui-pickers/cfg0zq670
✅ Preview: https://material-ui-pickers-git-fork-eps1lon-chore-peer-warnings.mui-org.vercel.app

eps1lon · 2020-08-01T09:52:22Z

docs/package.json

    "node": ">=8.0.0"
  },
  "dependencies": {
+    "@babel/core": "^7.9.6",


Fixes "missing peer"-warning.

eps1lon · 2020-08-01T09:52:44Z

docs/package.json

  },
  "dependencies": {
+    "@babel/core": "^7.9.6",
+    "@babel/plugin-proposal-nullish-coalescing-operator": "^7.8.3",


Was previously declared in the root but only used in the docs workspace.

eps1lon · 2020-08-01T09:52:52Z

docs/package.json

    "@material-ui/icons": "^4.9.1",
    "@material-ui/lab": "^4.0.0-alpha.54",
    "@material-ui/pickers": "^4.0.0-alpha.1",
+    "@mdx-js/mdx": "^0.15.7",


Fixes "missing peer"-warning

eps1lon · 2020-08-01T09:53:50Z

package.json

+    "**/@babel/core": "^7.9.6",
+    "**/webpack": "^4.43.0"


Technically next should declare it as a peer dependency with a default but that isn't supported in most package managers. In yarn v2 we will leverage packageExtensions instead of resolutions

eps1lon · 2020-08-01T09:54:05Z

package.json

+    "react": "^16.13.1",
+    "react-dom": "^16.13.1",
+    "typescript": "^3.9.6",


Fixes "missing peer"-warning.

eps1lon · 2020-08-01T09:54:09Z

package.json

+    "@babel/preset-env": "^7.9.6",
    "@babel/runtime": "^7.8.4",
    "@cypress/webpack-preprocessor": "^4.1.0",
+    "@material-ui/core": "^4.11.0",


Fixes "missing peer"-warning.

eps1lon · 2020-08-01T09:54:19Z

package.json

  },
  "devDependencies": {
-    "@babel/plugin-proposal-nullish-coalescing-operator": "^7.8.3",
+    "@babel/preset-env": "^7.9.6",


Fixes "missing peer"-warning.

eps1lon · 2020-08-01T09:54:56Z

lib/package.json

-    "eslint-plugin-react": "^7.19.0",
-    "eslint-plugin-react-hooks": "^4.0.5",


These are used in the .eslintrc in the root. Therefore they should be declared in the root package.json.

eps1lon · 2020-08-01T09:55:17Z

lib/package.json

    "codecov": "^3.7.1",
    "cross-env": "^7.0.2",
    "date-fns": "^2.12.0",
+    "dayjs": "^1.8.27",


Fixes "missing peer"-warning. Worked incidentally since it was hoisted from the docs workspace.

eps1lon · 2020-08-01T09:56:47Z

lib/package.json

-    "@typescript-eslint/eslint-plugin": "^1.6.0",
-    "@typescript-eslint/parser": "^1.6.0",


These are used in the .eslintrc in the root. Therefore they should be declared in the root package.json which was already the case. 1.x was unused but keeping them around can be dangerous with a lax package manger.

cypress · 2020-08-01T09:57:09Z

Test summary

78 • 0 • 3 • 0

Run details


Project	material-ui-pickers
Status	Passed
Commit	`f8fe066`
Started	Aug 1, 2020 9:55 AM
Ended	Aug 1, 2020 9:57 AM
Duration	01:26 💡
OS	Linux Debian - 10.0
Browser	Chrome 80

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

oliviertassinari · 2020-08-01T13:40:35Z

@eps1lon Regarding the migration plan of pickers into the main repository, the current proposed candidate approach is:

We hard merge pickers and main into a WIP repository, basically something identical to https://github.com/oliviertassinari/mui-merge/tree/master/packages/material-ui-pickers but with the latest code.
We set up the CI on this new temporary repository.
We drop all the tooling infrastructure from pickers (making the peer dependencies issues you are going after here vanish).
We work on getting the CI green, moving all the components into the /packages/material-ui-lab folder, moving the documentation into the /docs folder.
Once the CI is green, we backport the changes we had to do the main infrastructure to the main repository.
We do 1. once more, but this time for real, with the main repo, hopefully, it will Just work™.
We transfer all the existing issues of the pickers in the main repository.

What do you think about it?

eps1lon · 2020-08-01T14:03:45Z

I need to think about this a bit more. It seems like you're making things more complicated than necessary. There bigger, fundamental issues: how are the docs pages merged? Is pickers going core or lab?

This PR is important regardless of merging. Moving workspaces is just on use case that reveals issues with undeclared dependencies.

oliviertassinari · 2020-08-01T14:16:15Z

I need to think about this a bit more

Please do :)

how are the docs pages merged?

The documentation can be migrated, to the format of the main repository. We would need to replace the mdx syntax. But the demos are close to being usable as-is. We would still need to fix #1650 (e.g. use date-fns by default in the demos). But that isn't a blocker, it can be done incrementally.

I think that the main concern is the same one as we have with the data grid. How do we organize the navigation for components that require more than 1 page?

Is pickers going core or lab?

Maybe in the lab first? So it doesn't block us in 6 months if we are ready to cut a stable release but pickers aren't.

dmtrKovalenko

Thanks 😊

chore: Fix various peer dependency warnings

f8fe066

vercel bot deployed to Preview August 1, 2020 09:52 View deployment

eps1lon commented Aug 1, 2020

View reviewed changes

dmtrKovalenko approved these changes Aug 2, 2020

View reviewed changes

dmtrKovalenko merged commit 5424cdd into mui:next Aug 2, 2020

eps1lon deleted the chore/peer-warnings branch August 2, 2020 07:46

		"eslint-plugin-react": "^7.19.0",
		"eslint-plugin-react-hooks": "^4.0.5",

		"@typescript-eslint/eslint-plugin": "^1.6.0",
		"@typescript-eslint/parser": "^1.6.0",

chore: Fix various peer dependency warnings #2054

chore: Fix various peer dependency warnings #2054

Uh oh!

Conversation

eps1lon commented Aug 1, 2020

Uh oh!

vercel bot commented Aug 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eps1lon Aug 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cypress bot commented Aug 1, 2020

Test summary

Run details

Uh oh!

oliviertassinari commented Aug 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eps1lon commented Aug 1, 2020

Uh oh!

oliviertassinari commented Aug 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dmtrKovalenko left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel bot commented Aug 1, 2020 •

edited

Loading

eps1lon Aug 1, 2020 •

edited

Loading

oliviertassinari commented Aug 1, 2020 •

edited

Loading

oliviertassinari commented Aug 1, 2020 •

edited

Loading