Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

chore: Fix various peer dependency warnings #2054

Merged
merged 1 commit into from
Aug 2, 2020
Merged

chore: Fix various peer dependency warnings #2054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
"node": ">=8.0.0"
},
"dependencies": {
"@babel/core": "^7.9.6",
Copy link
Member Author

@eps1lon eps1lon Aug 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes "missing peer"-warning.

"@babel/plugin-proposal-nullish-coalescing-operator": "^7.8.3",
Copy link
Member Author

@eps1lon eps1lon Aug 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was previously declared in the root but only used in the docs workspace.

"@babel/plugin-proposal-optional-chaining": "^7.9.0",
"@date-io/hijri": "^2.6.0",
"@date-io/jalaali": "^2.6.0",
Expand All @@ -25,6 +27,7 @@
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "^4.0.0-alpha.54",
"@material-ui/pickers": "^4.0.0-alpha.1",
"@mdx-js/mdx": "^0.15.7",
Copy link
Member Author

@eps1lon eps1lon Aug 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes "missing peer"-warning

"@now/node": "^1.7.3",
"@types/fuzzy-search": "^2.1.0",
"@types/isomorphic-fetch": "^0.0.35",
Expand Down Expand Up @@ -73,6 +76,7 @@
"sinon": "^9.0.2",
"styled-jsx": "^3.3.0",
"typescript": "^3.9.6",
"webpack": "^4.43.0",
"yup": "^0.29.1"
},
"devDependencies": {
Expand Down
5 changes: 1 addition & 4 deletions lib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,18 +99,15 @@
"@types/react": "^16.9.35",
"@types/react-dom": "^16.9.8",
"@types/react-transition-group": "^4.2.4",
"@typescript-eslint/eslint-plugin": "^1.6.0",
"@typescript-eslint/parser": "^1.6.0",
Comment on lines -102 to -103
Copy link
Member Author

@eps1lon eps1lon Aug 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are used in the .eslintrc in the root. Therefore they should be declared in the root package.json which was already the case. 1.x was unused but keeping them around can be dangerous with a lax package manger.

"babel-loader": "^8.1.0",
"babel-plugin-optimize-clsx": "^2.6.1",
"babel-plugin-react-remove-properties": "^0.3.0",
"codecov": "^3.7.1",
"cross-env": "^7.0.2",
"date-fns": "^2.12.0",
"dayjs": "^1.8.27",
Copy link
Member Author

@eps1lon eps1lon Aug 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes "missing peer"-warning. Worked incidentally since it was hoisted from the docs workspace.

"enzyme": "^3.11.0",
"enzyme-adapter-react-16": "^1.15.2",
"eslint-plugin-react": "^7.19.0",
"eslint-plugin-react-hooks": "^4.0.5",
Comment on lines -112 to -113
Copy link
Member Author

@eps1lon eps1lon Aug 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are used in the .eslintrc in the root. Therefore they should be declared in the root package.json.

"fs-extra": "^9.0.0",
"full-icu": "^1.3.1",
"jest": "^26.1.0",
Expand Down
12 changes: 10 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,10 @@
"url": "git+https://github.com/mui-org/material-ui-pickers.git"
},
"devDependencies": {
"@babel/plugin-proposal-nullish-coalescing-operator": "^7.8.3",
"@babel/preset-env": "^7.9.6",
Copy link
Member Author

@eps1lon eps1lon Aug 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes "missing peer"-warning.

"@babel/runtime": "^7.8.4",
"@cypress/webpack-preprocessor": "^4.1.0",
"@material-ui/core": "^4.11.0",
Copy link
Member Author

@eps1lon eps1lon Aug 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes "missing peer"-warning.

"@percy/cypress": "^2.3.1",
"@testing-library/cypress": "^6.0.0",
"@testing-library/dom": "^7.21.5",
Expand All @@ -58,6 +59,9 @@
"husky": "^4.2.5",
"lint-staged": "^10.2.11",
"prettier": "^2.0.5",
"react": "^16.13.1",
"react-dom": "^16.13.1",
"typescript": "^3.9.6",
Comment on lines +62 to +64
Copy link
Member Author

@eps1lon eps1lon Aug 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes "missing peer"-warning.

"wait-on": "^5.1.0",
"yarn-deduplicate": "^2.1.1"
},
Expand All @@ -70,5 +74,9 @@
"/docs/_shared",
"/e2e/",
"**/build"
]
],
"resolutions": {
"**/@babel/core": "^7.9.6",
"**/webpack": "^4.43.0"
Comment on lines +79 to +80
Copy link
Member Author

@eps1lon eps1lon Aug 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically next should declare it as a peer dependency with a default but that isn't supported in most package managers. In yarn v2 we will leverage packageExtensions instead of resolutions

}
}
Loading