Add KeyboardButtonProps for spreading props onto Keyboard IconButton

[digitalkaoz]

Description

for better accessibility we derive an aria-label from the given (optional) label prop for the Adornment.

i thought about adding another prop to InputAdornmentProps. Not sure what might be the best option here. This is just a sensible default.

What is your opinion on this?

[codecov]

Codecov Report

Merging #842 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
- Coverage   92.74%   92.68%   -0.07%     
==========================================
  Files          47       40       -7     
  Lines        1337     1339       +2     
  Branches      168      168              
==========================================
+ Hits         1240     1241       +1     
- Misses         70       71       +1     
  Partials       27       27

Impacted Files	Coverage Δ
lib/src/_shared/DateTextField.tsx	87.94% <100%> (-4.65%)	⬇️
...c/DateTimePicker/components/DateTimePickerTabs.tsx	78.57% <0%> (-1.43%)	⬇️
lib/src/_shared/BasePicker.tsx	93.18% <0%> (-0.57%)	⬇️
lib/src/DatePicker/components/CalendarHeader.tsx	93.75% <0%> (-0.19%)	⬇️
lib/src/wrappers/InlineWrapper.tsx	84.48% <0%> (ø)	⬆️
lib/src/TimePicker/components/Clock.tsx	100% <0%> (ø)	⬆️
lib/src/DateTimePicker/DateTimePickerInline.tsx	100% <0%> (ø)	⬆️
lib/src/_helpers/date-utils.ts	100% <0%> (ø)	⬆️
lib/src/TimePicker/components/ClockPointer.tsx	96.55% <0%> (ø)	⬆️
... and 25 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d62621...c35ed26. Read the comment docs.

[dmtrKovalenko]

Here is a problem. We need to support different locales

[digitalkaoz]

Yeah, i thought about that too. So you suggest an additional prop? Dmitriy Kovalenko <[email protected]> schrieb am Mi., 9. Jan. 2019, 19:56:

…

***@***.**** commented on this pull request. Here is a problem. We need to support different locales — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#842 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAR612LCgS8CAJ_Evd5n6o4zfiQMSi63ks5vBZKmgaJpZM4Z2wcJ> .

[dmtrKovalenko]

@digitalkaoz here I see 2 possibilities. Add prop something like keyboardButtonProps which will be spread to the IconButton. Or create something like keyboardBtnAreaLabel={(label: string) => string}

[digitalkaoz]

i would go with keyboardButtonProps. sounds the most flexible, i'll update the PR

[dmtrKovalenko]

👍 lgtm

[dmtrKovalenko]

Find the IconButton by WithStyles(IconButton)

[digitalkaoz]

@dmtrKovalenko im afraid im too stupid. when i fetch the html output with html() all is fine...maybe you can help here?

[dmtrKovalenko]

Check the html with console.log(component.debug())

[digitalkaoz]

as i said, the "aria-label" is rendered! maybe you can take over, and give it the final polish?

[dmtrKovalenko]

Ok I will do

[digitalkaoz]

@dmtrKovalenko any news on that one?

[dmtrKovalenko]

@digitalkaoz will be included in the next release. I am pretty busy right now so will continue asap

[digitalkaoz]

no worries, didnt wanted to stress you! :)