This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Migrate from classnames to nicer clsx #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The size is slightly bigger because material ui still uses classnames but I'm working on it. |
Codecov Report
@@ Coverage Diff @@
## develop #855 +/- ##
==========================================
Coverage ? 92.75%
==========================================
Files ? 47
Lines ? 1338
Branches ? 171
==========================================
Hits ? 1241
Misses ? 70
Partials ? 27
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #855 +/- ##
==========================================
Coverage ? 92.75%
==========================================
Files ? 47
Lines ? 1338
Branches ? 171
==========================================
Hits ? 1241
Misses ? 70
Partials ? 27
Continue to review full report at Codecov.
|
Merged
dmtrKovalenko
added a commit
that referenced
this pull request
Jan 24, 2019
* Rename ExtendWrapper.d.ts to ExtendWrapper.ts to make it generate defenition file * Release 2.1.1 * [docs] Make code highlighting use dark theme in dark mode (#852) * Fix improper dispaying of highlighted code, use current theme for highlighting * Remove unused markup highlight syntax * [DateTimePicker] Add more consistent padding for 24h mode (#851) * Migrate from classnames to nicer clsx (#855) * Migrate from classnames to nicer clsx * Update size snapshot * Remove keycode in favour of event.key (#859) * Remove keycode in favour of event.key Ref https://twitter.com/olivtassinari/status/1084819202412818432 We can already see size improvement (which will be visible for end user only after material-ui upgrade) in 1.5kB. * Fix test * Fix direction of leaving item (#873) Fix incorrect leaving direction of Calendar animation * Add yarn example to README.md * Update packages (#878) * [#865] Properly type inputProps (#879) * [#865] Properly type inputProps * Add usage of InputLabelProps for checking typing of extended props * Add `KeyboardButtonProps` for spreading props onto Keyboard IconButton (#880) * add `KeyboardButtonProps` for Keyboard Icon Button (#842) * Add Unit test * Release 2.1.2
|
seems like my setup can't handle *.mjs files properly? |
Contributor
Author
|
@FranBran Do you use typescript? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description