[test] Decouple root class from root component #15168
Conversation
|
No bundle size changes comparing 638ca64...6ddb98a |
eps1lon
force-pushed
the
test/conformance-outermost
branch
2 times, most recently
from
a31a15a to
e17e5cc
Compare
| refInstanceof: window.HTMLSpanElement, | ||
| })); | ||
|
|
||
| /* TODO Switch violates root component |
There was a problem hiding this comment.
Oh yeah, I had forgotten about this one! :/ I have spent an afternoon trying to simplify the logic. I failed.
| inheritComponent: 'Transition', | ||
| mount, | ||
| skip: ['refForwarding'], | ||
| testComponentPropWith: false, |
There was a problem hiding this comment.
This will be removed in a final cleanup. This is legacy from before skip was available and when I had plans to test that it would not accept a component prop. It's consistent with the rest of the codebase.
| class: testClassName, | ||
| componentProp: testComponentProp, | ||
| mergeClassName: testClassName, | ||
| propsSpread: testPropsSpread, |
There was a problem hiding this comment.
Should we refactor this test to use the same strategy as testClassName (findOutermostIntrinsic)? Maybe we can use if for testComponentProp too 🤔.
There was a problem hiding this comment.
I see I still failed to explain why props spread is not bound to host components in our docs. If we say we spread to Paper we have to test for that. Not just the outermost host.
There was a problem hiding this comment.
This makes sense, thanks 👍. I was looking for a potential simplification of the tests.
eps1lon
force-pushed
the
test/conformance-outermost
branch
from
e17e5cc to
af4fc4f
Compare
These are separate concepts in the docs. The root class is applied to the root component. Not the root component has the root class. There's probably a good analogy in relational databases to be found
May be an enzyme bug. Can only find Transition by display name not constructor
eps1lon
force-pushed
the
test/conformance-outermost
branch
from
af4fc4f to
e4ecfd0
Compare
3 participants
Continues #15131. Using "root component = component that renders the outermost host" covers more components while also being testable.
The
rootclass is now (following the docs text) an afterthought. "Therootclass is applied to the root component." Not "The root component has the root class". The distinction is important since not every component has a root class. Since the description for therootclass can be different for each component we allowdescribeConformanceto signal that itsrootclass doesn't follow the usual definition.