Skip to content

Conversation

@avivkeller
Copy link
Member

@avivkeller avivkeller commented Oct 15, 2025

Replaces the use of the Google Calendar API with iCal, which not only lets us use non-Google providers, it also removes the need for a Google API token

@avivkeller avivkeller marked this pull request as ready for review October 15, 2025 20:57
Copilot AI review requested due to automatic review settings October 15, 2025 20:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates from Google Calendar API to iCal-based calendar integration, enabling support for non-Google calendar providers and eliminating the need for Google API authentication tokens.

  • Replaces Google Calendar API calls with iCal parsing for meeting date extraction
  • Updates all meeting configuration templates to use ICAL_URL instead of CALENDAR_ID
  • Removes Google API dependencies and authentication requirements

Reviewed Changes

Copilot reviewed 35 out of 38 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/google.mjs Completely removed - Google Calendar API client and meeting search logic
src/calendar.mjs New file implementing iCal-based meeting date finding
src/config.mjs Removed Google API configuration section
package.json Replaced @googleapis/calendar dependency with ical library
create-node-meeting-artifacts.mjs Updated to use new calendar module instead of Google API
test/config.test.mjs Removed Google API configuration tests
templates/* Updated all meeting templates to use ICAL_URL instead of CALENDAR_ID
README.md Removed Google API setup documentation
TEMPLATES_DOCUMENTATION.md Updated template property documentation
.github/workflows/* Removed GOOGLE_API_KEY environment variable
.env.example Removed Google API key configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@avivkeller
Copy link
Member Author

cc @ovflowd

Copilot AI review requested due to automatic review settings October 19, 2025 18:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 34 out of 37 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 20, 2025 22:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 34 out of 37 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 20, 2025 22:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 34 out of 37 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@avivkeller avivkeller marked this pull request as draft October 20, 2025 22:22
@avivkeller
Copy link
Member Author

(Drafting, as I need to work out an issue with UTC + iCal time zones

@avivkeller avivkeller marked this pull request as ready for review October 22, 2025 22:10
Copilot AI review requested due to automatic review settings October 22, 2025 22:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 34 out of 37 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@avivkeller
Copy link
Member Author

@ovflowd Ideally this will land, and then in a follow-up, I can do #196 + #189 in one shot

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, nevermind, I found something I thought got addressed but it didn't. (We're almost there tho!!)

@avivkeller avivkeller requested review from Copilot and ovflowd October 27, 2025 18:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 33 out of 36 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avivkeller
Copy link
Member Author

Bump @ovflowd, this should land soon, since LFX is now only using ical

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

@ovflowd ovflowd merged commit efa60e0 into nodejs:main Oct 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants