Skip to content

Compiler warning in cctest/inspector/test_network_requests_buffer.cc #60275

@targos

Description

@targos
In file included from ../../test/cctest/inspector/test_network_requests_buffer.cc:1:
../../deps/googletest/include/gtest/gtest.h:1394:11: warning: comparison of integers of different signs: 'const unsigned long' and 'const int' [-Wsign-compare]
 1394 |   if (lhs == rhs) {
      |       ~~~ ^  ~~~
../../deps/googletest/include/gtest/gtest.h:1413:12: note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long, int>' requested here
 1413 |     return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs);
      |            ^
../../test/cctest/inspector/test_network_requests_buffer.cc:171:5: note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned long, int, nullptr>' requested here
  171 |     EXPECT_EQ(buffer.total_buffer_size(), 15);
      |     ^
../../deps/googletest/include/gtest/gtest.h:1888:54: note: expanded from macro 'EXPECT_EQ'
 1888 |   EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2)
      |                                                      ^
1 warning generated.

Metadata

Metadata

Assignees

No one assigned

    Labels

    inspectorIssues and PRs related to the V8 inspector protocoltestIssues and PRs related to the tests.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions