Skip to content

Conversation

xiaocainiao633
Copy link

fix #60275

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 16, 2025
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2025
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Oct 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.57%. Comparing base (cec1bd5) to head (6ab957b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60281      +/-   ##
==========================================
- Coverage   88.58%   88.57%   -0.02%     
==========================================
  Files         704      704              
  Lines      208434   208434              
  Branches    40053    40048       -5     
==========================================
- Hits       184645   184612      -33     
- Misses      15812    15861      +49     
+ Partials     7977     7961      -16     

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas
Copy link
Member

Would you mind updating the commit message by following the guide at https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines? Thank you!

@xiaocainiao633 xiaocainiao633 changed the title src: fix small compile warning in test_network_requests_buffer.cc test: fix small compile warning in test_network_requests_buffer.cc Oct 20, 2025
@xiaocainiao633
Copy link
Author

Would you mind updating the commit message by following the guide at https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines? Thank you!
Can we merge now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compiler warning in cctest/inspector/test_network_requests_buffer.cc

5 participants