Skip to content

lib: add String primordials #31209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

lib: add String primordials #31209

wants to merge 3 commits into from

Conversation

@Sebastien-Ahkrin
Copy link
Contributor

Hello,
For this PR I have added String in the primordials eslint
And i just have created a line in "/lib/.eslintrc.yaml".

rules:
  no-restricted-globals:
  - name: String 
      message: "Use `const { String } = primordials;` instead of the global."

And just add String.

const {
  // [...]
  String,
} = primordials;

I hope this new PR will help you :x

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jan 6, 2020
@Sebastien-Ahkrin
Copy link
Contributor Author

Refs: #30697

BridgeAR
BridgeAR reviewed Jan 6, 2020
View reviewed changes
Trott
Trott requested changes Jan 7, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs fix to punycode. Just leaving this here so no one accidentally merges this one along with all the others.

@BridgeAR
Copy link
Member

BridgeAR commented Jan 9, 2020

This needs a rebase.

@BridgeAR BridgeAR added the wip Issues and PRs that are still a work in progress. label Jan 9, 2020
@Sebastien-Ahkrin Sebastien-Ahkrin requested a review from Trott May 29, 2020 09:37
targos
targos approved these changes May 29, 2020
View reviewed changes
lib/internal/readline/utils.js Outdated
const {
Symbol,
String,
Symbol
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the trailing comma

targos
targos reviewed May 31, 2020
View reviewed changes
@BridgeAR BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:19
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31829/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31859/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31860/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31865/

This was referenced Jun 18, 2020
Open
Open
@Sebastien-Ahkrin Sebastien-Ahkrin requested review from a team as code owners August 10, 2020 16:07
mcollina
mcollina approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@targos targos mentioned this pull request Sep 28, 2020
Closed
@targos
Copy link
Member

targos commented Sep 28, 2020

Superseded by #35397

@targos targos closed this Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targos targos targos approved these changes

@BridgeAR BridgeAR BridgeAR left review comments

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@trivikr trivikr trivikr approved these changes

@Trott Trott Awaiting requested review from Trott

Assignees

No one assigned

Labels

lib / src Issues and PRs related to general changes in the lib or src directory. wip Issues and PRs that are still a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Sebastien-Ahkrin @BridgeAR @nodejs-github-bot @targos @mcollina @jasnell @Trott @cjihrig @trivikr