assert: allow printf-style messages as assertion error

[BridgeAR]

Also add functions as allowed message input.
This allows to have heavy message computation to become cheaper.

This is not yet finished, I just thought I could get some early feedback.
Tests are often not as performance sensitive, so it's not that crucial.
I do like the ergonomics of it as well though and I know I worked around
a test perf issue of this kind in Node.js before.

[codecov]

Codecov Report

❌ Patch coverage is 96.62162% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.52%. Comparing base (7c85aa5) to head (67d2b7b).
⚠️ Report is 76 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/assert/utils.js	95.57%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58849      +/-   ##
==========================================
- Coverage   88.52%   88.52%   -0.01%     
==========================================
  Files         703      703              
  Lines      207825   207894      +69     
  Branches    40003    40016      +13     
==========================================
+ Hits       183976   184035      +59     
- Misses      15862    15867       +5     
- Partials     7987     7992       +5     

Files with missing lines	Coverage Δ
lib/assert.js	98.34% <100.00%> (-0.02%)	⬇️
lib/internal/test_runner/test.js	97.36% <100.00%> (ø)
lib/internal/assert/utils.js	97.26% <95.57%> (-2.74%)	⬇️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[BridgeAR]

@nodejs/assert @marco-ippolito PTAL

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69659/

[BridgeAR]

@nodejs/tsc PTAL, due to this being semver-major

[targos]

So the breaking change is that existing calls that happen to have printf syntax in the message give a different output?

[BridgeAR]

@targos for simple assert, using symbols would now throw. That is to make it consistent across the other methods and I think that should be fine to remove.

See https://github.com/nodejs/node/pull/58849/files#diff-968e57a9f4d4ce7494523f71b2594d844620c2794a68049cce33fcdc8c7c7b7cL907-L910

[targos]

Breaking change LGTM

[nodejs-github-bot]

Landed in d3f79aa

[joyeecheung]

This is breaking the linter on the main branch https://ci.nodejs.org/job/node-test-linter/62229/

[richardlau]

This is breaking the linter on the main branch https://ci.nodejs.org/job/node-test-linter/62229/

#60304 should fix the linter.