Skip to content

doc, assert: correct order of changes entries #60304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2025
Merged

doc, assert: correct order of changes entries #60304

merged 1 commit into from
Oct 18, 2025
+6 −6

Conversation

@Flarna
Copy link
Member

@Flarna Flarna commented Oct 17, 2025 •
edited
Loading

This should repair the md lint github action.

doc/api/assert.md
342:1-402:4 warning Items in `changes` list are not in order nodejs-yaml-comments remark-lint
545:1-597:4 warning Items in `changes` list are not in order nodejs-yaml-comments remark-lint

see https://github.com/nodejs/node/actions/runs/18606813117/job/53057819563?pr=60302

Refs: #58849

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Oct 17, 2025
@Flarna Flarna changed the title doc, assert: correct sequence of changes entries doc, assert: correct order of changes entries Oct 17, 2025
@Flarna Flarna force-pushed the assert-doc-sequence branch from 7095252 to d0d163f Compare October 17, 2025 23:17
@Flarna Flarna added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. labels Oct 18, 2025
@richardlau richardlau mentioned this pull request Oct 18, 2025
Closed
@richardlau richardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 18, 2025
@github-actions
Copy link
Contributor

Fast-track has been requested by @richardlau. Please 👍 to approve.

@BridgeAR BridgeAR added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2025
@richardlau richardlau mentioned this pull request Oct 18, 2025
Merged
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2025
@nodejs-github-bot nodejs-github-bot merged commit 382f7cf into nodejs:main Oct 18, 2025
31 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 382f7cf

@Flarna Flarna deleted the assert-doc-sequence branch October 18, 2025 15:18
aduh95 pushed a commit that referenced this pull request Oct 23, 2025
@Flarna @aduh95
doc, assert: correct order of changes entries
8a6de38 
PR-URL: #60304
Refs: #58849
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. review wanted PRs that need reviews.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Flarna @nodejs-github-bot @richardlau @BridgeAR