Skip to content

Conversation

anonymousRecords
Copy link
Member

@anonymousRecords anonymousRecords commented Sep 21, 2024

Description of Changes

Here is reference: #25


support 'Bulleted List Item' block

  • add custom solution for rendering 'Bulleted List Item' block.

Review point

  • Is the component structure clear and easy to understand?

To reproduce

  • npm run story:start
  • click 'your created block' on the Storybook left side panel

Screenshot

image

Review Guide

Reviews are conducted based on priority levels, such as p0, p1, p2, p3, p4, and p5.
p0 ~ p2: If the author decides not to reflect a review for p0 to p2, it signals that a proper discussion with the reviewer is
necessary. It is expected that the review will be resolved either through incorporating the feedback or through further discussion.
p3: indicates that the reviewer has identified a significant issue, but either lacks a clear solution or the comment lacks sufficient context. Further explanation or additional discussion on the reviewer's concerns is needed.
p4, p5: p4 and p5 suggest low priority, and if the author does not deem them important, these comments can be disregarded.

@Moon-DaeSeung Moon-DaeSeung added the enhancement New feature or request label Sep 22, 2024
@anonymousRecords anonymousRecords marked this pull request as ready for review September 26, 2024 11:19
@anonymousRecords anonymousRecords changed the title [DRAFT] - Implement BulletedListItem feat: add BulletedListItem Sep 26, 2024
list-style-type: none;
padding-left: 0;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p2: Please place the CSS at the very bottom to minimize merge conflicts.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p2: Please place the CSS at the very bottom to minimize merge conflicts.

I've moved the CSS to the very bottom of the file as requested.

@Moon-DaeSeung
Copy link
Contributor

p1: we have a pr template

could you edit your pr description regarding this: #28

@anonymousRecords
Copy link
Member Author

@Moon-DaeSeung

p1: we have a pr template

could you edit your pr description regarding this: #28

I've updated the PR description to follow the template provided in #28.

@Moon-DaeSeung
Copy link
Contributor

sorry for making your pr in merge conflict

could you resolve this?

@anonymousRecords
Copy link
Member Author

@Moon-DaeSeung

sorry for making your pr in merge conflict

could you resolve this?

Done

@Moon-DaeSeung Moon-DaeSeung merged commit 2c402ee into notionpresso:main Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants