Skip to content

Conversation

myjeong19
Copy link
Member

Description of Changes

Here is reference: #25


support 'Numbered List Item' block

  • add custom solution for rendering 'Numbered List Item block

Review point

  1. Is the current implementation of 'Numbered List Item block' efficient and maintainable?
  2. Any potential improvements for the 'Numbered List Item' block rendering logic?
  3. Are there any edge cases not covered by the current solution?

To reproduce

  • npm run story:start
  • click 'Numbered List Item' on the Storybook left side panel

Screenshot

스크린샷 2024-09-24 오후 7 46 06

Review Guide

Reviews are conducted based on priority levels, such as p0, p1, p2, p3, p4, and p5.
p0 ~ p2: If the author decides not to reflect a review for p0 to p2, it signals that a proper discussion with the reviewer is
necessary. It is expected that the review will be resolved either through incorporating the feedback or through further discussion.
p3: indicates that the reviewer has identified a significant issue, but either lacks a clear solution or the comment lacks sufficient context. Further explanation or additional discussion on the reviewer's concerns is needed.
p4, p5: p4 and p5 suggest low priority, and if the author does not deem them important, these comments can be disregarded.

@myjeong19 myjeong19 added the enhancement New feature or request label Sep 24, 2024
@myjeong19 myjeong19 changed the title Feature/numbered list Added Numberd List Sep 24, 2024
@myjeong19 myjeong19 changed the title Added Numberd List Added Numbered List Sep 24, 2024
@myjeong19 myjeong19 linked an issue Sep 24, 2024 that may be closed by this pull request
Copy link
Contributor

@Moon-DaeSeung Moon-DaeSeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gooood!!!!

@Moon-DaeSeung
Copy link
Contributor

could you resolve merge conflict??

@myjeong19
Copy link
Member Author

Yes, I will resolve the merge conflict. :)

@Moon-DaeSeung
Copy link
Contributor

haha, merge conflict happen again due to merging your another pr

check this

@Moon-DaeSeung Moon-DaeSeung merged commit 290f6a0 into main Sep 26, 2024
@Moon-DaeSeung Moon-DaeSeung deleted the feature/numbered-list branch September 26, 2024 13:46
@myjeong19
Copy link
Member Author

haha I have resolved the conflict right away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Notion Block] Support Numbered List block type

2 participants