feat!: read .env.test + allow overriding with nuxt.dotenv
#655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
approved these changes
Dec 17, 2023
danielroe
changed the title
.env.test and allow overriding with nuxt.dotenv options.env.test + allow overriding with nuxt.dotenv
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #646
This PR now reads in
.env.testwhen running vitest and allows the user to configure this withenvironmentOptions.nuxt.dotenv. (It's also possible to pass key/value pairs of environment rather than use.env.test, for example.)This currently uses a clone of the Nitro logic from https://github.com/unjs/nitro/tree/main/src/runtime/utils.env.ts but it would be nice to avoid duplication by using a normalised
nuxt.options.runtimeConfigin place (when nuxt/nuxt#24224 merges) which ideally would also involve exporting the utility from nitro (cc: @pi0).Note: This also changes the public API of
getVitestConfigFromNuxtwhich is currently only being used (as far as I can tell) by @wattanx in https://github.com/wattanx/nuxt-bridge-vitest - which is, anyway, a clone rather than direct usage.