-
Notifications
You must be signed in to change notification settings - Fork 350
Added MocoBushingForce class #4049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rrors do to the joint calls, not getting the right types or something.
… that actuator must be activated longer in order to achieve the task of sliding the mass. Co-authored-by: Nicos Haralabidis <[email protected]>
…mping component of the bushing. This allows the optimizer to change the damping coefficient - which effectively reduces it to zero, as one might expect. Co-authored-by: Jon Stingel <[email protected]> Co-authored-by: Nicos Haralabidis <[email protected]>
…ce. They are in agreement with both a spring and damper. Co-authored-by: Jon Stingel <[email protected]> Co-authored-by: Nicos Haralabidis <[email protected]>
Co-authored-by: Nicos Haralabidis <[email protected] Co-authored-by: Jon Stingel <[email protected]>
…edu>^Co-authored-by: Nicos Haralabidis <[email protected]>
Co-authored-by: Jon Stingel <[email protected]> Co-authored-by: Nicos Haralabidis <[email protected]>
Co-authored-by: Jon Stingel <[email protected]> Co-authored-by: Nicos Haralabidis <[email protected]>
Co-authored-by: Jon Stingel <[email protected]> Co-authored-by: Nicos Haralabidis <[email protected]>
Co-authored-by: Jon Stingel <[email protected]> Co-authored-by: Nicos Haralabidis <[email protected]>
Co-authored-by: Jon Stingel <[email protected]> Co-authored-by: Nicos Haralabidis <[email protected]>
|
@nicos1993, @stingjp, great work putting this together! I like starting from scratch to make sure that, when implemented correctly, a normal bushing force should work as expected. Unfortunately, it doesn't make too much sense to have two bushing force classes in OpenSim essentially performing the same job. It would be ideal to track down the real issue with Now that you have a working environment, it would be interesting to run a debugger through your |
|
Closing, as this is now redundant with the already merged #4054. |
Fixes issue #4042
Brief summary of changes
@stingjp and myself have created a new class,
MocoBushingForce. This class is based on the implementations ofExpressionBasedBushingForce(which works in Moco simulations) andBushingForce. It is essentially an implementation of a simple linear bushing, but to get around the issues we’ve found in the regularBushingForceclass.MocoBushingForcecalculates bushing stiffness and damping forces as perExpressionBasedBushingForce, but without expressions. In addition, this new class permits stiffness and damping properties to be optimized asMocoParameters.Testing I've completed
We have added a
MocoBushingForceto the sliding mass example, the code compiles and the solution converges. We have compared the bushing force outputs when performing the same sliding mass example but using aMocoBushingForceor anExpressionBasedBushingForce(constructed with the same parameters) and, as anticipated, the forces matched. Additionally, we have set up aMocoBushingForceparameter optimization and the solution converges. Lastly, we tested the bushing in the example2DWalking problem, and it leads to expected changes, and the problem converges well.Looking for feedback on...
Is the class name okay? And the location we have currently included the class? We wanted to get something working in Moco, and this was the fastest way to do so, but there is a discussion for incorporating this into one of the existing classes rather than a stand-alone.
CHANGELOG.md
Should probably update the log to reflect that this class has been added, but we can do this right at the end.
This change is