-
Notifications
You must be signed in to change notification settings - Fork 350
Expose the energy dissipation state variable in BushingForce
#4054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
FYI @nicos1993 and @stingjp. |
aymanhab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nickbianco)
CHANGELOG.md line 93 at r2 (raw file):
- Fixed bugs in `PolynomialPathFitter` when too few coordinate samples were provided. (#4039) - Exposed the "dissipated energy" state variable allocated by the `SimTK::Force::LinearBushing` that is internal to `BushingForce`. This changed fixed a bug in Moco, where adding a `BushingForce` led to a segfault due to a mismatch between the size of the
typo (changed -> change?)
aymanhab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nickbianco)
|
Thanks @aymanhab! |
Fixes issue #4042
Brief summary of changes
This change exposes the "dissipated energy" state variable allocated by the
SimTK::Force::LinearBushingthat is internal toBushingForce. This fixes the bug in #4042, which occurred because the size of the auxiliary state vector reserved by Moco did not matchSimTK::State::getZ(). This happened because Moco reserves state vectors based on the number of state variables reported by eachComponent, butBushingForcedid not report the "dissipated energy" state as part of the system, even though a slot for it is reserved in theSimTK::State.For convenience, I added the
Output"statebounds_dissipated_energy", which Moco will use to automatically set the bounds on the energy dissipation state variable (i.e., so users do not have to callsetStateInfo).Testing I've completed
Added tests to
testMocoInterface.cppandtestForces.cpp.Looking for feedback on...
CHANGELOG.md (choose one)
This change is