Add documentation for CPUID bit #64+17 #19670
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA: trivial
hlandau
approved these changes
Nov 14, 2022
hlandau
added
branch: master
paulidale
approved these changes
Nov 14, 2022
paulidale
added
the
approval: done
mattcaswell
added
the
tests: exempted
Collaborator
|
24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually. |
paulidale
added
approval: ready to merge
Contributor
|
@hlandau, confirm trivial? I think it is. |
hlandau
removed
the
approval: review pending
Member
|
Agree trivial. |
openssl-machine
pushed a commit
that referenced
this pull request
Nov 16, 2022
CLA: trivial Reviewed-by: Hugo Landau <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #19670)
Member
|
Merged to master, 3.0 and 3.1. Thank you. |
openssl-machine
pushed a commit
that referenced
this pull request
Nov 16, 2022
CLA: trivial Reviewed-by: Hugo Landau <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #19670) (cherry picked from commit ec76891)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 16, 2022
CLA: trivial Reviewed-by: Hugo Landau <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #19670) (cherry picked from commit ec76891)
beldmit
pushed a commit
to beldmit/openssl
that referenced
this pull request
Dec 26, 2022
CLA: trivial Reviewed-by: Hugo Landau <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from openssl#19670)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA: trivial
I'm not sure why bit # 64+17 was not documented, considering it is used in the code (e.g. https://github.com/openssl/openssl/blob/master/crypto/modes/asm/aes-gcm-avx512.pl#L81 and https://github.com/openssl/openssl/blob/master/crypto/bn/asm/rsaz-2k-avx512.pl).
On the other hand, it is omitted in other parts of the code:
Perhaps those files will need to be updated?