bib: update to images v0.177 #1017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supakeen
approved these changes
Aug 20, 2025
Member
supakeen
left a comment
supakeen
left a comment
There was a problem hiding this comment.
Yea, soon this is hopefully less or not at all necessary.
Collaborator
Author
|
Hrm, it looks like the centos9 based iso install test is hanging, I need to debug this further :/ |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
We no longer ship the blueprint package inside the images library but its now part of its own "blueprint" library.
This includes: - disk.ParitioningMode->parition.PartitioningMode - anaconda.AdditionalModules -> anaconda.EnabledModules - use of new InstallerCustomizations - aws uploader needs arch.Arch
Previously images [0] would take `AdditionalAnacondaModules`, i.e. we had a set of defaults in code with - anaconda.ModuleNetwork - anaconda.ModulePayloads - anaconda.ModuleRuntime - anaconda.ModuleStorage enabled by default. With the PR landed there are no longer default so we need to update our code to include those in the list of EnabledAnacondaModules. [0] Before osbuild/images#1737
Member
|
I can keep trying to add this to the merge queue, but will it ever merge? |
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Aug 25, 2025
This commit fixes the issue that with an unset --target-arch the code will try to convert an empty string to an arch.Arch which then fails. This is a regression from osbuild#1017 that was not caught.
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Aug 25, 2025
This commit fixes the issue that with an unset --target-arch the code will try to convert an empty string to an arch.Arch which then fails. This is a regression from osbuild#1017 that was not caught. Closes: osbuild#1029
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Aug 25, 2025
This commit fixes the issue that with an unset --target-arch the code will try to convert an empty string to an arch.Arch which then fails. This is a regression from osbuild#1017 that was not caught. Closes: osbuild#1029
This was referenced Aug 25, 2025
mvo5
added a commit
to mvo5/image-builder-cli
that referenced
this pull request
Nov 19, 2025
This commit fixes the issue that with an unset --target-arch the code will try to convert an empty string to an arch.Arch which then fails. This is a regression from osbuild/bootc-image-builder#1017 that was not caught. Closes: osbuild/bootc-image-builder#1029
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (or the need for it) indicates once more that we really
need to consolidate the manifest generation into the images
library (c.f. osbuild/images#1736) as
most of the adjustments would have one with the various
API changing changes in images if it was part of "images".
go.mod: update images to v0.177
image: update blueprint import path
We no longer ship the blueprint package inside the images library
but its now part of its own "blueprint" library.
main: update for v0.177 API changes
This includes:
bib: enable anaconda Module{Network,Payload,Runtime}
Previously images [0] would take
AdditionalAnacondaModules,i.e. we had a set of defaults in code with
enabled by default. With the PR landed there are no longer
default so we need to update our code to include those
in the list of EnabledAnacondaModules.
[0] Before osbuild/images#1737