bib: fix AWS upload with empty target-arch #1030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the issue that with an unset --target-arch the code will try to convert an empty string to an arch.Arch which then fails. This is a regression from osbuild#1017 that was not caught. Closes: osbuild#1029
Collaborator
Author
Absolutely! Initially I wanted to unblock people asap as this is a regression but we need a test. |
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Aug 27, 2025
This is a regression test to ensure the commandline handling of aws upload is correct. Its a followup for osbuild#1030
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Aug 27, 2025
This is a regression test to ensure the commandline handling of aws upload is correct. Its a followup for osbuild#1030
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Aug 27, 2025
This is a regression test to ensure the commandline handling of aws upload is correct. Its a followup for osbuild#1030
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Sep 8, 2025
This is a regression test to ensure the commandline handling of aws upload is correct. Its a followup for osbuild#1030
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Sep 9, 2025
This is a regression test to ensure the commandline handling of aws upload is correct. Its a followup for osbuild#1030
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Sep 10, 2025
This is a regression test to ensure the commandline handling of aws upload is correct. Its a followup for osbuild#1030
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Sep 15, 2025
This is a regression test to ensure the commandline handling of aws upload is correct. Its a followup for osbuild#1030
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Oct 6, 2025
This is a regression test to ensure the commandline handling of aws upload is correct. Its a followup for osbuild#1030
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Oct 29, 2025
This is a regression test to ensure the commandline handling of aws upload is correct. Its a followup for osbuild#1030
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 30, 2025
This is a regression test to ensure the commandline handling of aws upload is correct. Its a followup for #1030
mvo5
added a commit
to mvo5/image-builder-cli
that referenced
this pull request
Nov 19, 2025
This is a regression test to ensure the commandline handling of aws upload is correct. Its a followup for osbuild/bootc-image-builder#1030
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the issue that with an unset --target-arch the code will try to convert an empty string to an arch.Arch which then fails. This is a regression from
#1017 that was not caught.
Closes: #1029