Skip to content

bugfix for draw_property_layer #2639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 23, 2025
+4 −4
Merged

bugfix for draw_property_layer #2639

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
48d1bed
Update mpl_space_drawing.py
quaquel Jan 23, 2025
4a17ece
Update mpl_space_drawing.py
quaquel Jan 23, 2025
1ea215d
Update mpl_space_drawing.py
quaquel Jan 23, 2025
9a165eb
Update mpl_space_drawing.py
quaquel Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions mesa/visualization/mpl_space_drawing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,11 +191,10 @@ def draw_property_layers(
continue

data = layer.data.astype(float) if layer.data.dtype == bool else layer.data
width, height = data.shape # if space is None else (space.width, space.height)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest adding these two lines:

data = data.T
height, width = data.shape

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed your comments in a slightly different way but the effect is the same

if space and data.shape != (width, height):
if (space.width, space.height) != data.shape:
warnings.warn(
f"Layer {layer_name} dimensions ({data.shape}) do not match space dimensions ({width}, {height}).",
f"Layer {layer_name} dimensions ({data.shape}) do not match space dimensions ({space.width}, {space.height}).",
UserWarning,
stacklevel=2,
)
Expand All @@ -208,6 +207,7 @@ def draw_property_layers(

# Draw the layer
if "color" in portrayal:
data = data.T
rgba_color = to_rgba(portrayal["color"])
normalized_data = (data - vmin) / (vmax - vmin)
rgba_data = np.full((*data.shape, 4), rgba_color)
Expand All @@ -231,7 +231,7 @@ def draw_property_layers(
if isinstance(cmap, list):
cmap = LinearSegmentedColormap.from_list(layer_name, cmap)
im = ax.imshow(
data,
data.T,
cmap=cmap,
alpha=alpha,
vmin=vmin,
Expand Down
Loading