Remove use of cgroups #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
force-pushed
the
superq/cgroups
branch
from
3ca7ed4 to
b7ffaaf
Compare
Remove the use of cgroups from this exporter. This fuctionality overlaps too much with cAdvisor and is not systemd specific. Signed-off-by: SuperQ <[email protected]>
SuperQ
force-pushed
the
superq/cgroups
branch
from
b7ffaaf to
78863bc
Compare
povilasv
approved these changes
Oct 30, 2023
This was referenced Oct 30, 2023
SuperQ
added a commit
that referenced
this pull request
Oct 30, 2023
* [CHANGE] Remove broken metrics collection #68 * [CHANGE] Remove use of cgroups #105 * [FEATURE] Add unit timestamp metrics #58 Build updates: * Simplify build with CircleCI orb. * Upgrade to Go 1.21. * Switch form codespell to misspell linter. * Enable revive linter. * Removed unused func param. * Remove unnecessary promu build flags. * Move errcheck excludes inline. Signed-off-by: SuperQ <[email protected]>
Merged
SuperQ
added a commit
that referenced
this pull request
Oct 30, 2023
* [CHANGE] Remove broken metrics collection #68 * [CHANGE] Remove use of cgroups #105 * [FEATURE] Add unit timestamp metrics #58 Build updates: * Simplify build with CircleCI orb. * Upgrade to Go 1.21. * Switch form codespell to misspell linter. * Enable revive linter. * Removed unused func param. * Remove unnecessary promu build flags. * Move errcheck excludes inline. Signed-off-by: SuperQ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the use of cgroups from this exporter. This fuctionality overlaps too much with cAdvisor and is not systemd specific.