systemd.go: Added boot stage timestamp collector #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
reviewed
Nov 13, 2023
Contributor
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
A couple questions, otherwise looks good.
| } | ||
|
|
||
| func (c *Collector) collectBootStageTimestamps(conn *dbus.Conn, ch chan<- prometheus.Metric) error { | ||
| stages := []string{"Finish", "Firmware", "Loader", "Kernel", "InitRD", |
Contributor
There was a problem hiding this comment.
Hmm, there's no way to get the stage list dynamically is there?
Contributor
Author
There was a problem hiding this comment.
Not without embedding some of the C code - I doubt the list will change much going forward.
jpds
force-pushed
the
boot-timestamps
branch
2 times, most recently
from
c97631e to
f72a2b0
Compare
Signed-off-by: Jonathan Davies <[email protected]>
jpds
force-pushed
the
boot-timestamps
branch
from
f72a2b0 to
3c8aef5
Compare
SuperQ
approved these changes
Jan 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.