systemd.go: Added watchdog metrics #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpds
force-pushed
the
watchdog-metrics
branch
from
bdc3165 to
22901df
Compare
jpds
force-pushed
the
watchdog-metrics
branch
3 times, most recently
from
df26437 to
76ca157
Compare
SuperQ
reviewed
Jan 11, 2024
SuperQ
reviewed
Jan 11, 2024
Contributor
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
Minor nit about use of namespace/subsystem.
Also, I'm not so sure about the use of a regexp here, seems like an extra/expensive step to parse a number.
jpds
force-pushed
the
watchdog-metrics
branch
2 times, most recently
from
7487fb6 to
027a5a0
Compare
Contributor
Author
|
I retested this on a prod box and we need the regex to remove the |
jpds
force-pushed
the
watchdog-metrics
branch
from
027a5a0 to
8baf217
Compare
SuperQ
reviewed
Jan 12, 2024
Signed-off-by: Jonathan Davies <[email protected]>
jpds
force-pushed
the
watchdog-metrics
branch
from
8baf217 to
5aebeba
Compare
SuperQ
approved these changes
Jan 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.