-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Support NativeOutput
and PromptedOutput
modes in addition to ToolOutput
#1628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Preview
|
dmontagu
reviewed
May 2, 2025
dmontagu
reviewed
May 2, 2025
dmontagu
reviewed
May 2, 2025
dmontagu
reviewed
May 2, 2025
dmontagu
reviewed
May 2, 2025
dmontagu
reviewed
May 2, 2025
dmontagu
reviewed
May 2, 2025
dmontagu
reviewed
May 2, 2025
dmontagu
reviewed
May 2, 2025
dmontagu
reviewed
May 2, 2025
dmontagu
reviewed
May 2, 2025
dmontagu
reviewed
May 2, 2025
f305aa5
to
b892fc8
Compare
This was referenced May 20, 2025
2 tasks
# Conflicts: # tests/models/test_openai.py
samuelcolvin
requested changes
Jun 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looking good, but some docs and public api changes here.
# Conflicts: # tests/test_examples.py
dmontagu
reviewed
Jun 23, 2025
dmontagu
reviewed
Jun 23, 2025
dmontagu
reviewed
Jun 23, 2025
dmontagu
reviewed
Jun 23, 2025
dmontagu
reviewed
Jun 23, 2025
dmontagu
reviewed
Jun 23, 2025
dmontagu
reviewed
Jun 23, 2025
dmontagu
reviewed
Jun 23, 2025
dmontagu
reviewed
Jun 23, 2025
dmontagu
reviewed
Jun 23, 2025
…tput to PromptedOutput, and update docs
NativeOutput
and PromptedOutput
modes in addition to ToolOutput
Awesome, thank you!! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
output_type
in a dict (as we do with output tools), because while OpenAI supports them, our schema generation doesn'tToolOutput
andStructuredOutput
not preferred but forced, erroring if model doesn't support itStructuredOutput
TODO
sresponse_format=json_object
for older OpenAI models?