Eliminate final (!) implicit optional #1875
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrudd2
force-pushed
the
implicit-optional-final-boss
branch
from
7c15046 to
b1c5768
Compare
alexrudd2
force-pushed
the
implicit-optional-final-boss
branch
from
b1c5768 to
240f82d
Compare
Collaborator
Author
|
Closing in favor of #1888 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussions in #1856, which this supercedes
Note: CI will fail unless/until all the other PRs are merged.
EDIT: I rebased and fixed a pylint error.