-
Notifications
You must be signed in to change notification settings - Fork 125
API key, secure connections, and further small changes to Elastic connection wrapper #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR! However, I'm not sure if we want to bother about auth and API keys because we don't benchmark cloud deployments. Will think about this.
Co-authored-by: Kumar Shivendu <[email protected]>
Co-authored-by: Kumar Shivendu <[email protected]>
Co-authored-by: Kumar Shivendu <[email protected]>
@KShivendu I've removed the API key initialization. I've also extended the configurations that can be tuned and added extra checks concerning the index status and client connection. Please revise this current version |
Hi @filipecosta90, I've implemented your refactor in a slightly cleaner way #120 Also, I'm not sure if it makes sense to retry forcing ES into using 1 segment 30 times. Is there a simpler way to do this? |
we can wrap it around a backoff. but lets close this PR, merge your changes and then if needed I can open a 2nd iteration PR with further changes. |
This PR includes changes aimed at enhancing the Elastic connection wrapper.