refactor: Nested search params in ES config #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: filipe oliveira <[email protected]>
for more information, see https://pre-commit.ci
|
LGTM, thanks for pinging me on this 👍 |
filipecosta90
approved these changes
Apr 11, 2024
joein
reviewed
Apr 11, 2024
for more information, see https://pre-commit.ci
joein
reviewed
Apr 12, 2024
joein
reviewed
Apr 12, 2024
generall
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@filipecosta90 I realised that the problem with
parallelthat you highlighted in your PR #103 can be solved in a simpler way like this. We do the same with other engines.I've added you a co-author since parts of the code come from your PR :)