benchmarking in .dev/compare_branches #1375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshesITR
reviewed
Jun 9, 2022
AshesITR
reviewed
Jun 9, 2022
|
OK, I think extensions necessary to run Now to get some timings... |
MichaelChirico
changed the title
|
OK @AshesITR this is ready for review... .dev/compare_branches.R --branch=v2.0.1 --sample_size=20 --benchmark=true(not sure why |
AshesITR
approved these changes
Jun 12, 2022
| ) | ||
| ) | ||
| # delete noisy/redundant information from filename | ||
| timings_data[, filename := sub(file.path(tempdir(), .BY$package, ""), "", filename), by = package] |
There was a problem hiding this comment.
Nice gem. I didn't know about .BY 😄
There was a problem hiding this comment.
needed because sub doesn't vectorize on pattern
AshesITR
added a commit
that referenced
this pull request
Jun 12, 2022
* skeleton for new --benchmark parameter * incredibly hacky (but working on main at least) tracing approach * Rename old master branch to main in .dev/compare_branches * tweaks * run .Last() even interactively * debugging complete! works on main * handle --branch=$TAG * help mentions tag; git_branch_checkout doesnt work * need to git reset * robustly get linter call * cant rely on ~recent internal helper for encoding * remove remotes from temp repo * handle odd case of line_length_linter, muffle newline warnings * warn with tag names, not hashes * implement _all_ option for linters, skip more noisy warnings * fix default handling; simplify encoding test; correct branch-specific timings * combine timings, save output * save in wide format instead * comment * correct message * add a TODO * sum timing across expressions in output * correct data.table imports * refactor: use more helpers * consolidate more * another helper * more refactoring... pray this works * tweaks go get working * correct handling of timing output * add a TODO * clarify TODO * correct data.table imports again * more nesting! * one more helper * remove debugger * simplify warning message match Co-authored-by: AshesITR <[email protected]>
jimhester
added a commit
that referenced
this pull request
Jun 13, 2022
* change deprecated versions from 2.0.1.9001 to 3.0.0 fixes #835 * typo in NEWS (#1367) * Rename old master branch to main in .dev/compare_branches (#1372) * Deprecate find col (#1374) * first pass -- scorched earth * deprecate instead * whitespace * NEWS Co-authored-by: AshesITR <[email protected]> * Another round of NEWS polishing (#1370) * add reasoning to "return" removal * mention old argument still works * combine+clarify some brace_linter items, add attributions * consistent capitalization, clarifications * finish pass for consistent capitalizatoin * grammar * move object_name bullet with others; clarify cyclocomp bullet * mention CRAN policy re: cache directory * more consistently reference only the issue (not PR) #s * consistent capitalization in my GH username * missing item for any_duplicated_linter * improve description of system_file_linter * clarify strings_as_factors_linter, more grammar * more quantification of package speed-ups; more clarirfication * more removing redundant issue references; reorg bullet for get_source_expressions * clarification, remove redundant issue refs * move another object_name_linter bullet up * move extraction_operator item to "features" not bugs * trailing whitespace * trailing whitespace * feedback * lead with Deprecated * wording for object_usage * de-lint (#1378) * de-lint * tidyverse style, missing space Co-authored-by: Michael Chirico <[email protected]> * add tag "executing" to linters that call eval() or loadNamespace() on arbitrary input (#1383) * benchmarking in .dev/compare_branches (#1375) * skeleton for new --benchmark parameter * incredibly hacky (but working on main at least) tracing approach * Rename old master branch to main in .dev/compare_branches * tweaks * run .Last() even interactively * debugging complete! works on main * handle --branch=$TAG * help mentions tag; git_branch_checkout doesnt work * need to git reset * robustly get linter call * cant rely on ~recent internal helper for encoding * remove remotes from temp repo * handle odd case of line_length_linter, muffle newline warnings * warn with tag names, not hashes * implement _all_ option for linters, skip more noisy warnings * fix default handling; simplify encoding test; correct branch-specific timings * combine timings, save output * save in wide format instead * comment * correct message * add a TODO * sum timing across expressions in output * correct data.table imports * refactor: use more helpers * consolidate more * another helper * more refactoring... pray this works * tweaks go get working * correct handling of timing output * add a TODO * clarify TODO * correct data.table imports again * more nesting! * one more helper * remove debugger * simplify warning message match Co-authored-by: AshesITR <[email protected]> * Polish news (#1384) * consistent formatting * sort bullets alphabetically * add `allow_trailing = FALSE` to `missing_argument_linter()` (#1385) * update deprecations * usethis::use_version("major") * update reference checkstyle.xml Co-authored-by: Michael Chirico <[email protected]> Co-authored-by: Michael Chirico <[email protected]> Co-authored-by: Jim Hester <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #778
I'm having some hardware (software?) issue where the drive with my CRAN mirror keeps disconnecting itself, which makes a long-running comparison pretty tough. Hopefully figure that out soon (and anyway it's more motivation to support just ad hoc downloading packages from a mirror), but anyway we can merge this now.