Skip to content

benchmarking in .dev/compare_branches #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Jun 12, 2022
Merged

benchmarking in .dev/compare_branches #1375

Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
f0f9c39
skeleton for new --benchmark parameter
MichaelChirico Jun 7, 2022
f1dcf70
incredibly hacky (but working on main at least) tracing approach
MichaelChirico Jun 7, 2022
a16a61d
Rename old master branch to main in .dev/compare_branches
MichaelChirico Jun 8, 2022
a7ebf67
Merge branch 'default-branch' into compare-benchmark
MichaelChirico Jun 8, 2022
0603940
tweaks
MichaelChirico Jun 8, 2022
cf4de6f
Merge branch 'main' into compare-benchmark
MichaelChirico Jun 8, 2022
2b54e35
run .Last() even interactively
MichaelChirico Jun 8, 2022
7628b45
debugging complete! works on main
MichaelChirico Jun 8, 2022
9eb4bc0
handle --branch=$TAG
MichaelChirico Jun 8, 2022
4b9d383
help mentions tag; git_branch_checkout doesnt work
MichaelChirico Jun 8, 2022
2f9f2e5
need to git reset
MichaelChirico Jun 8, 2022
80bfca0
robustly get linter call
MichaelChirico Jun 8, 2022
28a61bd
cant rely on ~recent internal helper for encoding
MichaelChirico Jun 8, 2022
e12755a
remove remotes from temp repo
MichaelChirico Jun 9, 2022
df58c1a
handle odd case of line_length_linter, muffle newline warnings
MichaelChirico Jun 9, 2022
0ff3628
Merge branch 'main' into compare-benchmark
MichaelChirico Jun 9, 2022
6bbd357
warn with tag names, not hashes
MichaelChirico Jun 9, 2022
c0a5c18
implement _all_ option for linters, skip more noisy warnings
MichaelChirico Jun 9, 2022
23a5ec8
fix default handling; simplify encoding test; correct branch-specific…
MichaelChirico Jun 9, 2022
779a3b3
combine timings, save output
MichaelChirico Jun 9, 2022
f37f3d7
save in wide format instead
MichaelChirico Jun 9, 2022
9c557f0
comment
MichaelChirico Jun 9, 2022
bbc4265
correct message
MichaelChirico Jun 9, 2022
f6462dd
add a TODO
MichaelChirico Jun 9, 2022
a6b51a1
sum timing across expressions in output
MichaelChirico Jun 9, 2022
2ddeb51
correct data.table imports
MichaelChirico Jun 9, 2022
e95b23e
refactor: use more helpers
MichaelChirico Jun 9, 2022
b31216a
consolidate more
MichaelChirico Jun 9, 2022
37ae687
another helper
MichaelChirico Jun 9, 2022
93a4b39
more refactoring... pray this works
MichaelChirico Jun 9, 2022
a34e87d
tweaks go get working
MichaelChirico Jun 9, 2022
e5163b7
correct handling of timing output
MichaelChirico Jun 9, 2022
85182dc
add a TODO
MichaelChirico Jun 9, 2022
8dcfd74
clarify TODO
MichaelChirico Jun 9, 2022
6c1a5ed
correct data.table imports again
MichaelChirico Jun 9, 2022
546d0fb
more nesting!
MichaelChirico Jun 9, 2022
60bb2e3
one more helper
MichaelChirico Jun 9, 2022
1af497b
remove debugger
MichaelChirico Jun 9, 2022
84173e2
simplify warning message match
MichaelChirico Jun 9, 2022
40713d8
Merge branch 'main' into compare-benchmark
AshesITR Jun 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading