[ci] build anyscale images for gcp #41224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can-anyscale
force-pushed
the
can-rel-01
branch
4 times, most recently
from
36a6979 to
1edd73b
Compare
aslonnie
reviewed
Nov 17, 2023
ci/ray_ci/container.py
Outdated
Collaborator
There was a problem hiding this comment.
can we make this also controllable by the env var please?
Signed-off-by: can <[email protected]>
can-anyscale
force-pushed
the
can-rel-01
branch
from
1edd73b to
bb94f58
Compare
Contributor
Author
|
Make the gcp registry configurable through a env var. There is a yaml config that also contains this value, to make things configurable in another repo. However, the anyscale build code is this repo specific so I keep things simple for now. This might change on further unification. |
aslonnie
approved these changes
Nov 17, 2023
Signed-off-by: can <[email protected]>
liuxsh9
pushed a commit
to liuxsh9/ray
that referenced
this pull request
Nov 18, 2023
We need to build release test images for GCP as well. Add support for that. Currently GCP tests cannot run on PR because of this. Signed-off-by: can <[email protected]> Signed-off-by: Xiaoshuang Liu <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Nov 29, 2023
We need to build release test images for GCP as well. Add support for that. Currently GCP tests cannot run on PR because of this. Signed-off-by: can <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to build release test images for GCP as well. Add support for that. Currently GCP tests cannot run on PR because of this.
Test: