Skip to content

RDKTV-35185: Add sync between ssdp_http_server_callback and gdial_ssdp_set_friendlyname #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Parent: RDK-59367: Sync up xdialserver changes from RDKE
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

RDKTV-35185: Add sync between ssdp_http_server_callback and gdial_ssdp_set_friendlyname #136

wants to merge 5 commits into from

Conversation

@yuvaramachandran-gurusamy
Copy link
Contributor

RDKTV-35185: Add sync between ssdp_http_server_callback and gdial_ssdp_set_friendlyname

Signed-off-by: yuvaramachandran_gurusamy [[email protected]]

yuvaramachandran-gurusamy and others added 2 commits March 7, 2025 11:58
@yuvaramachandran-gurusamy @apatel859
RDKTV-35185: Add sync between ssdp_http_server_callback and gdial_ssd…
e825da1 
…p_set_friendlyname

Signed-off-by: yuvaramachandran_gurusamy <[email protected]>
@apatel859
Merge pull request #135 from apatel859/main
fc79027 
RDKTV-35185: Add sync between ssdp_http_server_callback and gdial_ssdp_set_friendlyname
@yuvaramachandran-gurusamy yuvaramachandran-gurusamy requested a review from a team as a code owner March 7, 2025 17:06
apatel859
apatel859 previously approved these changes Mar 7, 2025
View reviewed changes
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@yuvaramachandran-gurusamy @scthunderbolt
@sbarre01 @apatel859 @hgfell683 @tabbas651 @ssitar583 @mukesh972 @rdkcmf-jenkins @Alan-Ryan
RDK-59367: Sync up xdialserver changes from RDKE (#171) (#176)
652d90d 
* RDKECMF-213 Add CODEOWNERS file
* RDKEMW-254: libsoup3 support
* RDKTV-35185: Add sync between ssdp_http_server_callback and gdial_ssdp_set_friendlyname
* RDKEMW-2033: Fix coverity related issue
* RDK-55044: [RDKE] Implement DIAL requirement to use on EU product
* RDK-56672: Fix parsing issue while restrict addtionalData url per app
* RDKEMW-2278: Removal of WPEFrameworkSecurity Agent Utility
* RDKEMW-4129: Prepare native build environment
* RDKEMW-4129: Test
* RDKEMW-4129: Prepare native build script
* remmove duplicates from build_xxx script
* Update gdial.cpp
* RDKEMW-5927: Crash fix during soup_uri_to_string API call (#163)
* RDKEMW-6891:Coverity errors fix for xdial (#166)
* RDKEMW-6891: Coverity errors fix for xdial
* Update gdial.cpp
Fixed review comments
* Deploy cla action

---------

Signed-off-by: apatel859 <[email protected]>
Signed-off-by: yuvaramachandran_gurusamy <[email protected]>
Signed-off-by: Thamim Razith <[email protected]>
Co-authored-by: Simon Chung <[email protected]>
Co-authored-by: Stephen Barrett <[email protected]>
Co-authored-by: apatel859 <[email protected]>
Co-authored-by: apatel859 <[email protected]>
Co-authored-by: hgfell683 <[email protected]>
Co-authored-by: tabbas651 <[email protected]>
Co-authored-by: ssitar583 <[email protected]>
Co-authored-by: mukesh972 <[email protected]>
Co-authored-by: rdkcmf <[email protected]>
Co-authored-by: Alan Ryan <[email protected]>
@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"appName" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""appName"")" instead of "appName".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:1199

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"appId" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""appId"")" instead of "appId".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:816

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"appState" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""appState"")" instead of "appState".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:990

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"applicationName" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""applicationName"")" instead of "applicationName".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:988

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"appID" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""appID"")" instead of "appID".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:1188

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Parse recovery warning

a value of type "int" cannot be used to initialize an entity of type "SoupServerListenOptions"

Low Impact, CWE-none
RW.BAD_INITIALIZER_TYPE

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:295

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Parse recovery warning

function "gdialServiceImpl::start_GDialServer" not emitted, consider modeling it or review parse diagnostics to improve fidelity

Low Impact, CWE-none
RW.ROUTINE_NOT_EMITTED

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:222

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"applicationId" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""applicationId"")" instead of "applicationId".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:989

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Uninitialized pointer field

Non-static class member "m_observer" is not initialized in this constructor nor in any functions that it calls.

Medium Impact, CWE-457
UNINIT_CTOR

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/include/gdialserviceimpl.h:104

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"appId" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""appId"")" instead of "appId".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:792

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Parse recovery warning

argument of type "const char *" is incompatible with parameter of type "gpointer"

Low Impact, CWE-none
RW.INCOMPATIBLE_PARAM

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:379

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"appId" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""appId"")" instead of "appId".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:808

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"appName" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""appName"")" instead of "appName".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:1163

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"query" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""query"")" instead of "query".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:776

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Parse recovery warning

argument of type "const char *" is incompatible with parameter of type "gpointer"

Low Impact, CWE-none
RW.INCOMPATIBLE_PARAM

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:440

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Parse recovery warning

argument of type "const char *" is incompatible with parameter of type "gpointer"

Low Impact, CWE-none
RW.INCOMPATIBLE_PARAM

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:453

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"appID" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""appID"")" instead of "appID".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:1176

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"appName" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""appName"")" instead of "appName".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:1151

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Uninitialized scalar variable

Using uninitialized value "payload". Field "payload.user_param1" is uninitialized when calling "sendRequest".

High Impact, CWE-457
UNINIT

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:1057

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Uninitialized scalar variable

Using uninitialized value "payload". Field "payload.data_param" is uninitialized when calling "sendRequest".

High Impact, CWE-457
UNINIT

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:1028

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"error" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""error"")" instead of "error".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:991

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"appName" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""appName"")" instead of "appName".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:792

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"appID" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""appID"")" instead of "appID".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:1164

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"friendlyname" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""friendlyname"")" instead of "friendlyname".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:1008

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"appName" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""appName"")" instead of "appName".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:1175

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"payload" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""payload"")" instead of "payload".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:776

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"appID" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""appID"")" instead of "appID".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:1200

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"appName" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""appName"")" instead of "appName".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:808

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Uninitialized scalar variable

Using uninitialized value "payload". Field "payload.data_param" is uninitialized when calling "sendRequest".

High Impact, CWE-457
UNINIT

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:1073

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"appName" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""appName"")" instead of "appName".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:800

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"strAddDataUrl" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""strAddDataUrl"")" instead of "strAddDataUrl".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:1140

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"AddDataUrl" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""AddDataUrl"")" instead of "AddDataUrl".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:776

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"activation" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""activation"")" instead of "activation".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:1009

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Parse recovery warning

argument of type "const char *" is incompatible with parameter of type "gpointer"

Low Impact, CWE-none
RW.INCOMPATIBLE_PARAM

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:439

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Uninitialized scalar variable

Using uninitialized value "payload". Field "payload.data_param" is uninitialized when calling "sendRequest".

High Impact, CWE-457
UNINIT

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:1011

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Parse recovery warning

argument of type "const char *" is incompatible with parameter of type "gpointer"

Low Impact, CWE-none
RW.INCOMPATIBLE_PARAM

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:391

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"parameter" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""parameter"")" instead of "parameter".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:784

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Parse recovery warning

argument of type "const char *" is incompatible with parameter of type "gpointer"

Low Impact, CWE-none
RW.INCOMPATIBLE_PARAM

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:415

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Uninitialized scalar variable

Using uninitialized value "payload". Field "payload.data_param" is uninitialized when calling "sendRequest".

High Impact, CWE-457
UNINIT

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:992

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"strPayLoad" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""strPayLoad"")" instead of "strPayLoad".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:1138

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"friendlyname" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""friendlyname"")" instead of "friendlyname".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:1027

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"appId" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""appId"")" instead of "appId".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:800

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"appName" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""appName"")" instead of "appName".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:1137

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"appName" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""appName"")" instead of "appName".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:776

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Parse recovery warning

argument of type "const char *" is incompatible with parameter of type "gpointer"

Low Impact, CWE-none
RW.INCOMPATIBLE_PARAM

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:403

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"strQuery" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""strQuery"")" instead of "strQuery".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:1139

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"appName" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""appName"")" instead of "appName".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:816

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"appName" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""appName"")" instead of "appName".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:1187

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"powerState" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""powerState"")" instead of "powerState".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:1216

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Variable copied when it could be moved

"appName" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""appName"")" instead of "appName".

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
server/gdialservice.cpp:784

rdkcmf-jenkins
rdkcmf-jenkins reviewed Oct 23, 2025
View reviewed changes
server/gdialservice.cpp
{
RequestHandlerPayload payload;
payload.event = UPDATE_MANUFACTURER_NAME;
payload.manufacturer = manufacturer;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Variable copied when it could be moved

"manufacturer" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""manufacturer"")" instead of "manufacturer".

server/gdialservice.cpp
{
RequestHandlerPayload payload;
payload.event = UPDATE_MODEL_NAME;
payload.model = model;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Variable copied when it could be moved

"model" is copied in call to copy assignment for class "std::string", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""model"")" instead of "model".

server/gdialservice.cpp
RequestHandlerPayload payload;
payload.event = UPDATE_MODEL_NAME;
payload.model = model;
gdialImplInstance->sendRequest(payload);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Uninitialized scalar variable

Using uninitialized value "payload". Field "payload.data_param" is uninitialized when calling "sendRequest".

High Impact, CWE-457
UNINIT

server/gdialservice.cpp
RequestHandlerPayload payload;
payload.event = UPDATE_MANUFACTURER_NAME;
payload.manufacturer = manufacturer;
gdialImplInstance->sendRequest(payload);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Uninitialized scalar variable

Using uninitialized value "payload". Field "payload.data_param" is uninitialized when calling "sendRequest".

High Impact, CWE-457
UNINIT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdkcmf-jenkins rdkcmf-jenkins rdkcmf-jenkins left review comments

@apatel859 apatel859 apatel859 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yuvaramachandran-gurusamy @rdkcmf-jenkins @apatel859 @Alan-Ryan