Skip to content

Conversation

@bkniffler
Copy link

Hey, how about beautifying the JSON and using <pre> instead of <div> for better styling?

screen

@danielkcz
Copy link
Contributor

This might be a quite long for bigger states and frequent actions being dispatched. It might be much more interesting to have a kind of collapsing in there instead of showing everything it all by default. But I guess that will be covered in more advanced monitors as they emerge for sure.

@gaearon
Copy link
Contributor

gaearon commented Aug 4, 2015

I'm inclined to merge this until somebody implements collapsing.
Any objections?

@gaearon
Copy link
Contributor

gaearon commented Aug 4, 2015

For bigger states, select prop helps to focus on a particular part. <DevTools select={state => state.todos} />

@gaearon
Copy link
Contributor

gaearon commented Aug 4, 2015

I played with it some more.. I'm not sure this is very helpful.
Deeply nested JSON is still painful to view.

I have another idea which I'll post shortly.
(Thanks for effort though!)

@bkniffler
Copy link
Author

How about this? A fresh timeline and horizontal scrolling for better JSON display?
Uses bootstrap, fontawesome, and http://bootsnipp.com/snippets/featured/timeline-responsive

devtool-1
devtool-2
devtool-3

@calesce
Copy link
Contributor

calesce commented Aug 5, 2015

I agree that a drop down (similar to the Chrome extension, JSON Formatter) would be most helpful.

@bkniffler
Copy link
Author

Though its even less space horizontally now..

@gaearon
Copy link
Contributor

gaearon commented Aug 5, 2015

Some thoughts here: #38.
Maybe these should be two separate monitors.

@bkniffler
Copy link
Author

I imagine your proposition would be the best solution, though its a bit more complex to implement. The current monitor as well as this proposition here are merely temporary solutions.

devtool-1
devtool-2

@bkniffler
Copy link
Author

I think I like the last commit best, what do you think? Until the dock-monitor is done, we can still polish the simple-monitor. Or would you my changes to live as a fork, as a seperate monitor?

@gaearon
Copy link
Contributor

gaearon commented Aug 5, 2015

Thank you! Let's hear what others have to say. With a bit of design polish I think this is a good temporary solution.

@bkniffler
Copy link
Author

This is what it looks like now, horizontally scrollable, separately expandable action and state using <pre/> and a disable/enable label:
devtool

I'll leave it like that for now, waiting for feedback.

@danielkcz
Copy link
Contributor

@bkniffler I love it! As a temporary solution it's definitely very good. +1 for merge

@bkniffler
Copy link
Author

dev

@gaearon
Copy link
Contributor

gaearon commented Aug 6, 2015

Hmm, here's how I see TodoMVC example in your branch:

screen shot 2015-08-06 at 20 12 11

Another problem is lots of linting errors:

screen shot 2015-08-06 at 20 13 03

@gaearon
Copy link
Contributor

gaearon commented Aug 12, 2015

Thanks for your effort! In the end we went with #48 because it also had a tree inspector.

@gaearon gaearon closed this Aug 12, 2015
@bkniffler
Copy link
Author

Ah, no worries, it looks a lot better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants