-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Improved design and tree for devtools #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Conflicts: package.json
|
Some screenshots would be nice ;-) |
|
I think it's a bit more ambitious than #36 |
|
Well I am simply amazed. Definitely step forward compared to the current simple thing :) Although doesn't make much sense to me to display Also it might be nice to have an option to just collapse whole action (perhaps even by default) instead of just disabling it. Another neat idea that just struck me is about displaying time of an action since we have it in there now. |
|
Updated description of features in original post |
|
@FredyC 3 items is displayed only when the tree is not expanded (useful to know how many array items or object keys you have in state) |
|
I want some people who use DevTools to give it a go on a real project before merging and let us know any point points. Any volunteers? |
|
@dzannotti Yeah I am not sure if knowing number of keys is useful anywhere :) Perhaps you can change that label to display "3 keys" instead? This way it's easily confused with array and adds more complexity your brains has to pay attention to. |
|
Collapsing the whole action is something i did think about today, but the ui to do that would require additional things (ie fontawesome?) which would complicate the distribution of the package, unsure about this one. |
* Use flexbox for alignment * Add more obvious disabled state * Add more subtle hover state
|
+1 on @nicinabox theme used as default and his tweaking |
|
Anything else here? I can't wait to merge. :-) |
Improved design and tree for devtools
|
Awesome job. I'm so grateful to you @dzannotti @nicinabox. |
|
👏👏 as are we all. This is awesome. |
|
Looks like I am too late in here. Seems you forgot about that support for Immutable. I didn't actually tried, I just don't see where it's taken care of. Might be just looking at wrong places, in that case nevermind :) And good job, looks great (at least from the picture) |
|
Out in 1.0 |
|
Please file an issue for supporting Immutable. |
|
Thanks guys! I added #52 to continue polishing. If you spot issues just give a shout. |

<LogMonitor/>(defaulting to ocean)Here is a screenshot of what it looks like using ocean's theme

Original PR:
With changes:
