-
Notifications
You must be signed in to change notification settings - Fork 54
feat: adds permissive mode for batch API #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 issues found across 5 files
React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
… based on the option (#605) Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But since I made so many changes I think it would be nice to get the eyes of somebody else too
Co-authored-by: Gabriel Miranda <[email protected]> Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
This PR is related to this feature.
Basically it should allow to call batch API with header
x-batch-validation
.If the header value is
permissive
, it should expect to receive a fielderrors
withdata
.This should NOT cause a breaking change.
For that, if no header is provided, we guarantee that no field
errors
will be returned.Summary by cubic
Adds a permissive mode to the Batch API. When clients send x-batch-validation=permissive, responses can include an errors array for partial failures; without it, the SDK omits errors to preserve the old response shape (no breaking change).