-
Notifications
You must be signed in to change notification settings - Fork 54
feat: specific option to pass in the header, and type-safe definition based on the option #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pedro-stramantinoli
merged 10 commits into
feat/batch-mode-permissive
from
chore/suggestions-to-batch-mode-api
Aug 27, 2025
Merged
feat: specific option to pass in the header, and type-safe definition based on the option #605
pedro-stramantinoli
merged 10 commits into
feat/batch-mode-permissive
from
chore/suggestions-to-batch-mode-api
Aug 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n mode, and make it type-safe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 issues found across 2 files
React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
commit: |
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
pedro-stramantinoli
approved these changes
Aug 27, 2025
Nice!! |
e1165fa
into
feat/batch-mode-permissive
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a stacked change on #599. The idea for this is that users can pass in if they want then permissive or strict validation on an option, so the usage would be like:
This options also allows us to use typescript's inference on type parameters to automatically change the return type to not have the
errors
whenbatchValidation
is'strict'
.Summary by cubic
Adds a batchValidation option to Batch.send/create that sets the x-batch-validation header automatically. Responses are now type-safe: errors are only present when using permissive mode.
New Features
Migration