Skip to content

Conversation

abcxff
Copy link
Collaborator

@abcxff abcxff commented Jun 10, 2025

No description provided.

@abcxff abcxff marked this pull request as ready for review June 10, 2025 03:00
Copy link
Collaborator Author

abcxff commented Jun 10, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Comment on lines 72 to 75
let mut options = GetOrCreateOptions {
tags: Some(tags),
..Default::default()
};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GetOrCreateOptions struct has been refactored in this update and no longer contains a tags field. This example needs to be updated to use the new API structure, which now uses key instead of tags. The correct approach would be:

let key = vec![
    "general".to_string(),
];

let options = GetOrCreateOptions::default();

let room = client.get_or_create("chatRoom", key, options)?
    .connect();

This matches the updated client API signature shown elsewhere in the changes.

Suggested change
let mut options = GetOrCreateOptions {
tags: Some(tags),
..Default::default()
};
let key = vec![
"general".to_string(),
];
let options = GetOrCreateOptions::default();

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@NathanFlurry NathanFlurry changed the base branch from main to graphite-base/984 June 19, 2025 18:24
@NathanFlurry NathanFlurry force-pushed the 06-09-feat_update_rust_to_0.9.0 branch from 9e4ec66 to 7ca9225 Compare June 19, 2025 18:24
@NathanFlurry NathanFlurry changed the base branch from graphite-base/984 to 06-11-refactor_react_0.9 June 19, 2025 18:24
@jog1t jog1t changed the base branch from 06-11-refactor_react_0.9 to graphite-base/984 June 19, 2025 21:41
@NathanFlurry NathanFlurry changed the base branch from graphite-base/984 to 06-11-refactor_react_0.9 June 20, 2025 00:09
@jog1t jog1t changed the base branch from 06-11-refactor_react_0.9 to graphite-base/984 June 20, 2025 00:12
@NathanFlurry NathanFlurry changed the base branch from graphite-base/984 to 06-11-refactor_react_0.9 June 20, 2025 01:02
@jog1t jog1t force-pushed the 06-11-refactor_react_0.9 branch from 749fb1f to af5e352 Compare June 20, 2025 01:07
@jog1t jog1t force-pushed the 06-09-feat_update_rust_to_0.9.0 branch from 7ca9225 to 49f1a8b Compare June 20, 2025 01:07
@jog1t jog1t force-pushed the 06-11-refactor_react_0.9 branch from 749fb1f to af5e352 Compare June 26, 2025 19:27
@jog1t jog1t force-pushed the 06-09-feat_update_rust_to_0.9.0 branch from 7ca9225 to 49f1a8b Compare June 26, 2025 19:27
@jog1t jog1t mentioned this pull request Jun 26, 2025
@NathanFlurry NathanFlurry force-pushed the 06-09-feat_update_rust_to_0.9.0 branch from 49f1a8b to 7ca9225 Compare June 27, 2025 08:43
@NathanFlurry NathanFlurry force-pushed the 06-11-refactor_react_0.9 branch from af5e352 to 749fb1f Compare June 27, 2025 08:43
Copy link

graphite-app bot commented Jun 27, 2025

Merge activity

  • Jun 27, 8:53 AM UTC: NathanFlurry added this pull request to the Graphite merge queue.
  • Jun 27, 8:55 AM UTC: CI is running for this pull request on a draft pull request (#1030) due to your merge queue CI optimization settings.
  • Jun 27, 8:56 AM UTC: Merged by the Graphite merge queue via draft PR: #1030.

graphite-app bot pushed a commit that referenced this pull request Jun 27, 2025
@graphite-app graphite-app bot closed this Jun 27, 2025
@graphite-app graphite-app bot deleted the 06-09-feat_update_rust_to_0.9.0 branch June 27, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant