Skip to content

chore: implement Registry.run #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore: implement Registry.run #998

wants to merge 1 commit into from

Conversation

NathanFlurry
Copy link
Member

No description provided.

This was referenced Jun 20, 2025
Closed
Closed
Closed
Closed
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Jun 20, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@NathanFlurry NathanFlurry mentioned this pull request Jun 20, 2025
Closed
@NathanFlurry NathanFlurry marked this pull request as ready for review June 20, 2025 00:10
@NathanFlurry NathanFlurry force-pushed the 06-19-chore_implement_registry.run_ branch from 54133a7 to a230b3a Compare June 20, 2025 00:12
graphite-app[bot]
graphite-app bot reviewed Jun 20, 2025
View reviewed changes
examples/hono/src/server.ts
// Setup router
const app = new Hono();

// Expose RivetKit to the frontend (optinoal)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the comment on line 16 of examples/hono/src/server.ts: "optinoal" should be "optional".

Suggested change
// Expose RivetKit to the frontend (optinoal)
// Expose RivetKit to the frontend (optional)

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@NathanFlurry NathanFlurry force-pushed the 06-19-chore_implement_registry.run_ branch from a230b3a to a241276 Compare June 20, 2025 01:02
@jog1t jog1t force-pushed the 06-19-chore_migrate_to_pnpm branch from 3ff7699 to a08ff6e Compare June 20, 2025 01:07
@jog1t jog1t force-pushed the 06-19-chore_implement_registry.run_ branch from a241276 to 0420874 Compare June 20, 2025 01:07
@NathanFlurry NathanFlurry force-pushed the 06-19-chore_migrate_to_pnpm branch from a08ff6e to 3ff7699 Compare June 20, 2025 01:09
@NathanFlurry NathanFlurry force-pushed the 06-19-chore_implement_registry.run_ branch from 0420874 to 576e671 Compare June 20, 2025 01:09
@jog1t jog1t force-pushed the 06-19-chore_migrate_to_pnpm branch from 3ff7699 to a08ff6e Compare June 20, 2025 07:50
@jog1t jog1t force-pushed the 06-19-chore_implement_registry.run_ branch from 576e671 to 1df6f03 Compare June 20, 2025 07:50
@NathanFlurry NathanFlurry force-pushed the 06-19-chore_implement_registry.run_ branch from 1df6f03 to c87e31e Compare June 20, 2025 16:37
@NathanFlurry NathanFlurry force-pushed the 06-19-chore_migrate_to_pnpm branch from a08ff6e to 3ff7699 Compare June 20, 2025 16:37
This was referenced Jun 20, 2025
Closed
Closed
Closed
@NathanFlurry NathanFlurry force-pushed the 06-19-chore_migrate_to_pnpm branch from 3ff7699 to cda6da1 Compare June 21, 2025 01:57
@NathanFlurry NathanFlurry force-pushed the 06-19-chore_implement_registry.run_ branch from c87e31e to 65754e2 Compare June 21, 2025 01:57
@jog1t jog1t force-pushed the 06-19-chore_migrate_to_pnpm branch from cda6da1 to d57c122 Compare June 23, 2025 18:56
@jog1t jog1t force-pushed the 06-19-chore_implement_registry.run_ branch from 65754e2 to 32c5f6a Compare June 23, 2025 18:56
This was referenced Jun 23, 2025
Closed
Closed
Closed
Closed
This was referenced Jun 26, 2025
Closed
Closed
@jog1t jog1t force-pushed the 06-19-chore_migrate_to_pnpm branch from cda6da1 to d57c122 Compare June 26, 2025 19:27
@jog1t jog1t force-pushed the 06-19-chore_implement_registry.run_ branch from 65754e2 to 32c5f6a Compare June 26, 2025 19:27
@jog1t jog1t mentioned this pull request Jun 26, 2025
Draft
@NathanFlurry NathanFlurry force-pushed the 06-19-chore_migrate_to_pnpm branch from d57c122 to cda6da1 Compare June 27, 2025 08:43
@NathanFlurry NathanFlurry force-pushed the 06-19-chore_implement_registry.run_ branch from 32c5f6a to 65754e2 Compare June 27, 2025 08:43
This was referenced Jun 27, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@graphite-app Graphite App
Copy link

graphite-app bot commented Jun 27, 2025 •
edited
Loading

Merge activity

  • Jun 27, 8:53 AM UTC: NathanFlurry added this pull request to the Graphite merge queue.
  • Jun 27, 8:55 AM UTC: CI is running for this pull request on a draft pull request (#1030) due to your merge queue CI optimization settings.
  • Jun 27, 8:56 AM UTC: Merged by the Graphite merge queue via draft PR: #1030.

graphite-app bot pushed a commit that referenced this pull request Jun 27, 2025
@NathanFlurry
chore: implement Registry.run (#998)
3f08a5a
@graphite-app graphite-app bot closed this Jun 27, 2025
@graphite-app graphite-app bot deleted the 06-19-chore_implement_registry.run_ branch June 27, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NathanFlurry