This repository was archived by the owner on Aug 3, 2020. It is now read-only.
Use urdf::*SharedPtr instead of boost::shared_ptr (#144) #182
+91
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use urdf::*SharedPtr instead of boost::shared_ptr urdfdom_headers uses C++ std::shared_ptr. As it exports it as a custom *SharedPtr type, we can use them to stay compatible. * Add compatibility urdf::VoidSharedPtr * Use urdfdom compatibility header * Build kinetic for kinetic branch * Add missing namespace and includes * Revert "Build kinetic for kinetic branch" This reverts commit f1c085c. * Add build dependency * Revert "Add build dependency" This reverts commit 9417509. * Export urdfdom version to header * Add dummy version in case it's not set by urdfdom_headers * Add missing header
wjwwood
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #144 to indigo.
This is similar in spirit to #170 and aims to maintain compatibility
between robot_model's indigo and kinetic branches and ease transition.