Update from master #857
Merged
Update from master #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [assert_inhabited](https://doc.rust-lang.org/std/intrinsics/fn.assert_inhabited.html) intrinsic will (possibly) panic if a type in uninhabited (cannot be instantiated). E.g. ```rust assert_inhabited<!>(); // panics (probably) assert_inhabited<u8>(); // does nothing ``` Despite being an `assert`, panicking is not guaranteed and is dependent on the target and code generation - it is sound to perform a NO OP. Since calling the intrinsic comes from a `TerminatorKind::Call`, there must be a `BasicBlock` to go to after the call. However we observe that for `assert_inhabited<!>()` the execution continues to `noBasicBlockIdx` (which would get stuck). The semantics looks for this case and converts to `#AssertInhabitedFailure`, and otherwise performs a `NO OP`.
Co-authored-by: devops <[email protected]> Co-authored-by: Daniel Cumming <[email protected]>
* declares that `#intAsType` and `littleEndianFromBytes` equations preserve definedness (booster should apply them) * removes round-trips from (symbolic) `discriminant` to `variantIdx` and back * simplifies repeated bit shifts and asserts magnitude limit for byte-sliced values
Conflicts: kmir/src/kmir/kdist/mir-semantics/lemmas/kmir-lemmas.md (previous squash-merge of mapOffset simplification)
jberthold
requested review from
Stevengre,
dkcumming and
tothtamas28
and removed request for
tothtamas28
dkcumming
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_inhabitedimplementationstable-mir-jsonupgrade