Skip to content

Conversation

bigduu
Copy link
Contributor

@bigduu bigduu commented Mar 25, 2023

@matthiasbeyer
Copy link
Member

Hi,
sorry for the slow response, I was on vacation.

The patch itself looks good. But I am slowly getting the impression that the whole env-parsing implementation was a mistake. It gets more and more complex.

Still, I give this a go for now.

@matthiasbeyer
Copy link
Member

Care to make CI green here? 😃

@bigduu
Copy link
Contributor Author

bigduu commented Jul 21, 2023

sorry,late reply,will let the CI green later: )

@bigduu
Copy link
Contributor Author

bigduu commented Jul 21, 2023

The commit check detail is overdue, could you please approve the workflows?

@matthiasbeyer
Copy link
Member

Done.
The signoff is missing. Please rebase and signoff your commit (and remove the merge commit).

@bigduu
Copy link
Contributor Author

bigduu commented Jul 21, 2023

Thanks, done

@bigduu
Copy link
Contributor Author

bigduu commented Jul 24, 2023

do we have any updates? Please help to merge the PR, thanks

@matthiasbeyer matthiasbeyer merged commit 2ebe44a into rust-cli:master Jul 24, 2023
@matthiasbeyer
Copy link
Member

Thanks for reminding me!

@bigduu
Copy link
Contributor Author

bigduu commented Jul 24, 2023

Np,Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants